chrome/renderer/content_settings_observer.cc - Issue 1905033002: PlzNavigate: Move navigation-level mixed content checks to the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/content_settings_observer.cc

Issue 1905033002: PlzNavigate: Move navigation-level mixed content checks to the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@console-security-message

Patch Set: Moved methods from ContentBrowserClient to WebContentsDelegate; all caps constant names. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/mixed_content_settings.cc ('K') | « chrome/browser/ui/tab_helpers.cc ('k') | content/browser/BUILD.gn » ('j') | content/browser/frame_host/mixed_content_navigation_throttle.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/content_settings_observer.cc

diff --git a/chrome/renderer/content_settings_observer.cc b/chrome/renderer/content_settings_observer.cc

index afbaab30f3b3dbf5533629e2e07589799e96cc44..23b45c886de86a8f4846371b50576c4a9513705a 100644

--- a/chrome/renderer/content_settings_observer.cc

+++ b/chrome/renderer/content_settings_observer.cc

@@ -388,6 +388,8 @@ bool ContentSettingsObserver::allowRunningInsecureContent(

bool allowed_per_settings,

const blink::WebSecurityOrigin& origin,

const blink::WebURL& resource_url) {

+ // Note: this implementation is a mirror of

+ // Browser::ShouldAllowRunningInsecureContent.

FilteredReportInsecureContentRan(GURL(resource_url));

if (!allow_running_insecure_content_ && !allowed_per_settings) {