PlzNavigate: Move navigation-level mixed content checks to the browser.

third_party/WebKit/Source/core/loader/MixedContentChecker.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 164 matching lines @@
     default:
         NOTREACHED();
         return;
     }
     UseCounter::count(frame, feature);
 }
 
 // static
 bool MixedContentChecker::shouldBlockFetch(LocalFrame* frame, WebURLRequest::RequestContext requestContext, WebURLRequest::FrameType frameType, ResourceRequest::RedirectStatus redirectStatus, const KURL& url, MixedContentChecker::ReportingStatus reportingStatus)
 {
+    // Frame-level loads are checked by the browser. No need to check them again here.
+    if (frameType != WebURLRequest::FrameTypeNone)
+        return false;

[carlosk, 2016/07/18 14:37:13]

Can anyone confirm this is the correct filter for ignoring main resource (frame
navigation) loads? It seems to work...

+
     Frame* effectiveFrame = effectiveFrameForFrameType(frame, frameType);
     Frame* mixedFrame = inWhichFrameIsContentMixed(effectiveFrame, frameType, url);
     if (!mixedFrame)
         return false;
 
     MixedContentChecker::count(mixedFrame, requestContext);
     if (ContentSecurityPolicy* policy = frame->securityContext()->contentSecurityPolicy())
         policy->reportMixedContent(url, redirectStatus);
 
     Settings* settings = mixedFrame->settings();
@@ skipping 197 matching lines @@
     // See comment in shouldBlockFetch() about loading the main resource of a subframe.
     if (request.frameType() == WebURLRequest::FrameTypeNested && !SchemeRegistry::shouldTreatURLSchemeAsCORSEnabled(request.url().protocol())) {
         return WebMixedContent::ContextType::OptionallyBlockable;
     }
 
     bool strictMixedContentCheckingForPlugin = mixedFrame->settings() && mixedFrame->settings()->strictMixedContentCheckingForPlugin();
     return WebMixedContent::contextTypeFromRequestContext(request.requestContext(), strictMixedContentCheckingForPlugin);
 }
 
 } // namespace blink