content/browser/frame_host/DEPS - Issue 1905033002: PlzNavigate: Move navigation-level mixed content checks to the browser.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/frame_host/DEPS

Issue 1905033002: PlzNavigate: Move navigation-level mixed content checks to the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@console-security-message

Patch Set: Overall code cleanup to request reviewers to PTAL. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/content_settings/content/common/content_settings_messages.h ('K') | « components/content_settings/content/common/content_settings_messages.h ('k') | content/browser/frame_host/mixed_content_navigation_throttle.h » ('j') | content/browser/frame_host/mixed_content_navigation_throttle.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # The frame_host files should only call upwards in the layering via the	2 # The frame_host files should only call upwards in the layering via the

3 # delegate interfaces.	3 # delegate interfaces.

4 "-content/browser/web_contents",	4 "-content/browser/web_contents",

5 "-content/public/browser/web_contents.h",	5 "-content/public/browser/web_contents.h",

6 "-content/public/browser/web_contents_delegate.h",	6 "-content/public/browser/web_contents_delegate.h",

7 "-content/public/browser/web_contents_view.h",	7 "-content/public/browser/web_contents_view.h",

8	8

9 "+third_party/kasko",	9 "+third_party/kasko",

10 ]	10 ]

11	11

12 specific_include_rules = {	12 specific_include_rules = {

13 ".*_(unit\|browser)test\.cc": [	13 ".*_(unit\|browser)test\.cc": [

14 "+content/browser/web_contents",	14 "+content/browser/web_contents",

15 "+content/public/browser/web_contents.h",	15 "+content/public/browser/web_contents.h",

16 "+content/public/browser/web_contents_delegate.h",	16 "+content/public/browser/web_contents_delegate.h",

17 ],	17 ],

18 ".*interstitial_page_impl\.cc": [	18 ".*interstitial_page_impl\.cc": [

19 # TODO(nasko): This should be removed once we remove	19 # TODO(nasko): This should be removed once we remove

20 # WebContentsObserver as the method of telling interstitial pages to	20 # WebContentsObserver as the method of telling interstitial pages to

21 # clean themselves up.	21 # clean themselves up.

22 "+content/browser/web_contents",	22 "+content/browser/web_contents",

23 "+content/public/browser/web_contents_delegate.h",	23 "+content/public/browser/web_contents_delegate.h",

24 ],	24 ],

	25 "mixed_content_navigation_throttle\.(cc\|h)": [

	26 "+third_party/WebKit/public/platform/WebMixedContent.h",

	27 ],
	carlosk 2016/07/18 14:37:13 This include seems to conform to what I see in con This include seems to conform to what I see in content/browser/DEPS. But should it be added there instead of here?
25 }	28 }

OLD	NEW