PlzNavigate: Move navigation-level mixed content checks to the browser.

content/public/browser/web_contents_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 
 #include <stdint.h>
 
 #include <set>
@@ skipping 48 matching lines @@
 namespace gfx {
 class Point;
 class Rect;
 class Size;
 }
 
 namespace net {
 class X509Certificate;
 }
 
+namespace url {
+class Origin;
+}
+
 namespace blink {
 class WebGestureEvent;
 }
 
 namespace content {
 
 struct OpenURLParams;
 struct WebContentsUnresponsiveState;
 
 // Objects implement this interface to get notified about changes in the
@@ skipping 469 matching lines @@
 
   // Called when the active render widget is forwarding a RemoteChannel
   // compositor proto.  This is used in Blimp mode.
   virtual void ForwardCompositorProto(
       RenderWidgetHost* render_widget_host,
       const std::vector<uint8_t>& proto) {}
 
   // Requests the app banner. This method is called from the DevTools.
   virtual void RequestAppBannerFromDevTools(content::WebContents* web_contents);
 
+  // Reports that passive mixed content was found at the specified url.
+  virtual void PassiveInsecureContentFound(const GURL& resource_url) {}
+
+  // Checks if running of active mixed-content is allowed for the specified
+  // WebContents/tab.
+  virtual bool ShouldAllowRunningInsecureContent(bool allowed_per_settings,

[nasko, 2017/01/12 18:32:38]

nit: Shouldn't this be "allower_per_prefs"? When I read settings, I thought
immediately content settings, which are maintained by the chrome/ layer and got
confused. Tracing the code, the value comes from WebPreferences.

[carlosk, 2017/01/21 02:54:59]

I'm just following the pattern used in MixedContentsChecked for the mirror API
[1]. I didn't understand your explanation.

[1]
https://cs.chromium.org/chromium/src/chrome/renderer/content_settings_observe...

[nasko, 2017/01/23 22:32:37]

My comment meant to say that the source of the input is WebPreferences and not
ContentSettings, so naming the variable to indicate where it comes from makes it
easier to understand.

[carlosk, 2017/02/08 02:59:02]

Understood this time and agreed. Changed all cases accordingly.

+                                                 const url::Origin& origin,
+                                                 const GURL& resource_url,
+                                                 WebContents* web_contents);

[nasko, 2017/01/12 18:32:38]

Let's keep WebContents as the first parameter to be consistent with the rest of
the delegate methods and since it is the context in which this call is made.

[carlosk, 2017/01/21 02:54:59]

Done.

+
  protected:
   virtual ~WebContentsDelegate();
 
  private:
   friend class WebContentsImpl;
 
   // Called when |this| becomes the WebContentsDelegate for |source|.
   void Attach(WebContents* source);
 
   // Called when |this| is no longer the WebContentsDelegate for |source|.
   void Detach(WebContents* source);
 
   // The WebContents that this is currently a delegate for.
   std::set<WebContents*> attached_contents_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_