Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 1905013002: Refine tracking of snippet dismissals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index 243e1aad337c3032a058b685d72483d7969c8eaf..bcf7c50bf120eae9f94b4e9d5b450f17045c2e81 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -22,6 +22,7 @@ import android.view.MenuItem.OnMenuItemClickListener;
import android.view.View;
import org.chromium.base.ApiCompatibilityUtils;
+import org.chromium.base.Callback;
import org.chromium.base.CommandLine;
import org.chromium.base.VisibleForTesting;
import org.chromium.base.metrics.RecordHistogram;
@@ -540,7 +541,16 @@ public class NewTabPage
@Override
public void onSnippetDismissed(SnippetArticle dismissedSnippet) {
if (mIsDestroyed) return;
- NewTabPageUma.recordSnippetAction(NewTabPageUma.SNIPPETS_ACTION_DISMISSED);
+
+ mSnippetsBridge.getSnippedVisited(dismissedSnippet, new Callback<Boolean>() {
+ @Override
+ public void onResult(Boolean result) {
+ NewTabPageUma.recordSnippetAction(result
+ ? NewTabPageUma.SNIPPETS_ACTION_DISMISSED_VISITED
+ : NewTabPageUma.SNIPPETS_ACTION_DISMISSED_UNVISITED);
+ }
+ });
+
mSnippetsBridge.discardSnippet(dismissedSnippet);
}

Powered by Google App Engine
This is Rietveld 408576698