Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1904993002: Remove a non-existent test from android disabled tests (Closed)

Created:
4 years, 8 months ago by Stephen Chennney
Modified:
4 years, 8 months ago
Reviewers:
Sami
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a non-existent test from android disabled tests RenderViewTest.onMsgPaintAtSize no longer exists, so the expectation can be removed. R=skyostil@chromium.org BUG=139095 Committed: https://crrev.com/c5fd675b1a146fd1b71265fa256aa988c0444560 Cr-Commit-Position: refs/heads/master@{#388803}

Patch Set 1 : Corrected #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/android/pylib/gtest/filter/unit_tests_disabled View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904993002/1
4 years, 8 months ago (2016-04-21 14:23:58 UTC) #2
Stephen Chennney
An old bug was triaged to us and it turns out the test in question ...
4 years, 8 months ago (2016-04-21 14:24:15 UTC) #3
Stephen Chennney
Oops. Too aggressive.
4 years, 8 months ago (2016-04-21 14:25:21 UTC) #5
Stephen Chennney
Right this time.
4 years, 8 months ago (2016-04-21 14:37:59 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904993002/20001
4 years, 8 months ago (2016-04-21 14:38:00 UTC) #9
Sami
lgtm.
4 years, 8 months ago (2016-04-21 14:59:23 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-21 17:24:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904993002/20001
4 years, 8 months ago (2016-04-21 17:25:52 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-04-21 17:31:06 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:35:47 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c5fd675b1a146fd1b71265fa256aa988c0444560
Cr-Commit-Position: refs/heads/master@{#388803}

Powered by Google App Engine
This is Rietveld 408576698