Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 1904943003: Remove obsolete image codec colorspace hacks. (Closed)

Created:
4 years, 8 months ago by Brian Osman
Modified:
4 years, 8 months ago
Reviewers:
msarett, herb_g
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove obsolete image codec colorspace hacks. With Herb's latest change, the codecs themselves are emitting images tagged based on the new (separate) global flag. All of the changes we had here to fixup color profile type are no longer needed (and just create more confusion). This change effectively reverts the file to where it was two commits ago. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1904943003 Committed: https://skia.googlesource.com/skia/+/0370712fd50d7187277cfe42d8564aa1f6cfedca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -17 lines) Patch
M src/codec/SkCodecImageGenerator.cpp View 2 chunks +5 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904943003/1
4 years, 8 months ago (2016-04-21 15:21:14 UTC) #3
Brian Osman
4 years, 8 months ago (2016-04-21 15:21:27 UTC) #5
msarett
LGTM Woohoo thanks!
4 years, 8 months ago (2016-04-21 15:27:12 UTC) #6
herb_g
lgtm
4 years, 8 months ago (2016-04-21 15:29:49 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-21 15:43:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904943003/1
4 years, 8 months ago (2016-04-21 15:47:26 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 15:48:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0370712fd50d7187277cfe42d8564aa1f6cfedca

Powered by Google App Engine
This is Rietveld 408576698