Make querySelectorAll a generic method so that checked mode behavior is consistent with existing be…

Make querySelectorAll a generic method so that checked mode behavior is consistent with existing behavior and strong mode behavior is strong for the case of List<InputElement> elems = document.querySelector("input");

BUG=
R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/9ffe1c24509e97e20e930cebccebb4e486568cef

[Jacob, 2016-04-21 16:31:46]

jacobr@google.com changed reviewers:
+ alanknight@google.com, leafp@google.com

[Jacob, 2016-04-21 16:31:47]

Make querySelectorAll a generic method
so that checked mode behavior is consistent with existing behavior
and strong mode behavior is strong
for the case
of
List<InputElement> elems = document.querySelector("input");

[Leaf, 2016-04-21 16:41:01]

lgtm for the strong mode types part

https://codereview.chromium.org/1904903003/diff/1/sdk/lib/html/dart2js/html_d...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/1904903003/diff/1/sdk/lib/html/dart2js/html_d...
sdk/lib/html/dart2js/html_dart2js.dart:10609: +  ElementList/*<T>*/
querySelectorAll/*<T extends Element>*/(String selectors) =>
If you care about non-strong mode analysis, you might want to write this as:

ElementList<Element /*=T*/> querySelectorAll and similarly below, so that
non-strong mode analysis will still see ElementList<Element>.

If not, not.

[Jacob, 2016-04-21 16:53:55]

https://codereview.chromium.org/1904903003/diff/1/sdk/lib/html/dart2js/html_d...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/1904903003/diff/1/sdk/lib/html/dart2js/html_d...
sdk/lib/html/dart2js/html_dart2js.dart:10609: +  ElementList/*<T>*/
querySelectorAll/*<T extends Element>*/(String selectors) =>
On 2016/04/21 16:41:01, Leaf wrote:
> If you care about non-strong mode analysis, you might want to write this as:
> 
> ElementList<Element /*=T*/> querySelectorAll and similarly below, so that
> non-strong mode analysis will still see ElementList<Element>.
> 
> If not, not.
Good catch. Switched to this version everywhere.

[Jacob, 2016-04-21 16:54:23]

Description was changed from

==========
Make querySelectorAll a generic method so that checked mode behavior is
consistent with existing behavior and strong mode behavior is strong for the
case of List<InputElement> elems = document.querySelector("input");

BUG=
==========

to

==========
Make querySelectorAll a generic method so that checked mode behavior is
consistent with existing behavior and strong mode behavior is strong for the
case of List<InputElement> elems = document.querySelector("input");

BUG=
R=leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9ffe1c24509e97e20e930cebccebb4e486568cef
==========

[Jacob, 2016-04-21 16:54:24]

Committed patchset #3 (id:40001) manually as
9ffe1c24509e97e20e930cebccebb4e486568cef.

[Alan Knight, 2016-04-21 17:03:42]

lgtm

[sra1, 2016-04-21 22:43:14]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2016-04-21 22:43:15]

This pattern is currently much better tolerated by dart2js.

https://codereview.chromium.org/1904903003/diff/40001/tools/dom/templates/htm...
File tools/dom/templates/html/impl/impl_Element.darttemplate (right):

https://codereview.chromium.org/1904903003/diff/40001/tools/dom/templates/htm...
tools/dom/templates/html/impl/impl_Element.darttemplate:283: E operator [](int
index) => _nodeList[index] as E;
E _asE(Node node) {
  E element = node;
  return element;
}

E operator [](int index) => _asE(_nodeList[index]);

https://codereview.chromium.org/1904903003/diff/40001/tools/dom/templates/htm...
tools/dom/templates/html/impl/impl_Element.darttemplate:301: E get first =>
_nodeList.first as E;
=> _asE(_nodeList.first);