Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1904873002: Remove flaky timeout suppression for TexImage2D with RGB/UNSIGNED_BYTE. (Closed)

Created:
4 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 8 months ago
Reviewers:
haraken, Zhenyao Mo
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, jochen (gone - plz use gerrit), sigbjornf
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove flaky timeout suppression for TexImage2D with RGB/UNSIGNED_BYTE. An unscientific sampling of linux_chromium_rel_ng try jobs shows that this test is not flakily failing any more. I suspect the fix for Issue 586183 has fixed it, and am going to duplicate Issue 596622 into it. BUG=596622 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/33fe94fcfa642ddc4a8c02c5eebee5d9211dc0f1 Cr-Commit-Position: refs/heads/master@{#388671}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Ken Russell (switch to Gerrit)
zmo: please review. haraken, jochen, sigbjornf: FYI.
4 years, 8 months ago (2016-04-21 00:22:52 UTC) #3
Zhenyao Mo
lgtm
4 years, 8 months ago (2016-04-21 00:24:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904873002/1
4 years, 8 months ago (2016-04-21 00:30:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/216078)
4 years, 8 months ago (2016-04-21 01:18:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904873002/1
4 years, 8 months ago (2016-04-21 01:22:22 UTC) #10
haraken
LGTM
4 years, 8 months ago (2016-04-21 01:43:01 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 03:05:32 UTC) #12
Ken Russell (switch to Gerrit)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1910553003/ by kbr@chromium.org. ...
4 years, 8 months ago (2016-04-21 17:54:50 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:30:45 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33fe94fcfa642ddc4a8c02c5eebee5d9211dc0f1
Cr-Commit-Position: refs/heads/master@{#388671}

Powered by Google App Engine
This is Rietveld 408576698