Issue 1904833002: Ignore invalid error code in QuicFramer when process GoAway, ConnectionClose,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1904833002: Ignore invalid error code in QuicFramer when process GoAway, ConnectionClose, (Closed)

Created:
4 years, 8 months ago by Ryan Hamilton

Modified:
4 years, 8 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@119529330

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Ignore invalid error code in QuicFramer when process GoAway, ConnectionClose, RstStream frames to do normal goaway, connection close, and stream reset. Flag protected by FLAGS_quic_ignore_invalid_error_code. Merge internal change: 119551887 BUG=

Patch Set 1 #

Patch Set 2 : unset flag in test #

Patch Set 3 : Rebase #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -7 lines)			Patch
M	net/quic/quic_flags.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_flags.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/quic/quic_framer.cc	View		3 chunks	+22 lines, -7 lines	0 comments	Download
M	net/quic/quic_network_transaction_unittest.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1907683002 Patch 1

Dependent Patchsets:

Issue 1897153007 Patch 40001

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages