Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/shim/main.js

Issue 190483002: Remove 'writable:false' from webview.request's definition since false is (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/resources/extensions/web_view.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/platform_apps/web_view/shim/main.js
diff --git a/chrome/test/data/extensions/platform_apps/web_view/shim/main.js b/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
index 0ba8d81f4b81ffe3ffa87d3d99d7a7dd55afe502..647c3b7762a453e71069aa7327a6917c02828a7e 100644
--- a/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
+++ b/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
@@ -386,6 +386,11 @@ function testWebRequestAPIExistence() {
'function',
typeof webview.request[apiPropertiesToCheck[i]].removeRules);
}
+
+ // Try to overwrite webview.request, shall not succeed.
+ webview.request = '123';
+ embedder.test.assertTrue(typeof webview.request !== 'string');
+
embedder.test.succeed();
});
webview.setAttribute('src', 'data:text/html,webview check api');
« no previous file with comments | « chrome/renderer/resources/extensions/web_view.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698