chrome/renderer/resources/extensions/web_view.js - Issue 190483002: Remove 'writable:false' from webview.request's definition since false is

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 190483002: Remove 'writable:false' from webview.request's definition since false is (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/resources/extensions/web_view.js

diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js

index 2e69ba9a48609e897bf4b6234d3fd48706d84b51..b0189af96f57ea0798c382499f2c2bf82f3dbfa9 100644

--- a/chrome/renderer/resources/extensions/web_view.js

+++ b/chrome/renderer/resources/extensions/web_view.js

@@ -896,8 +896,7 @@ WebViewInternal.prototype.setupWebRequestEvents = function() {

'request',

{

value: request,

- enumerable: true,

- writable: false

+ enumerable: true

}

);

};

« no previous file with comments | « no previous file | chrome/test/data/extensions/platform_apps/web_view/shim/main.js » ('j') | no next file with comments »