Issue 190483002: Remove 'writable:false' from webview.request's definition since false is

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 190483002: Remove 'writable:false' from webview.request's definition since false is (Closed)

Created:
6 years, 9 months ago by lazyboy

Modified:
6 years, 9 months ago

Reviewers:
Fady Samuel

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove 'writable:false' from webview.request's definition since false is default for writable. BUG=None Test=No visible change, cleanup only. Updated and ran browser_tests:WebViewTest.Shim_TestWebRequestAPIExistence Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255785

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	chrome/renderer/resources/extensions/web_view.js	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	chrome/test/data/extensions/platform_apps/web_view/shim/main.js	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/190483002/1

6 years, 9 months ago (2014-03-07 17:28:31 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/190483002/1

6 years, 9 months ago (2014-03-07 20:17:00 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/190483002/1

6 years, 9 months ago (2014-03-08 10:47:31 UTC) #6

Message was sent while issue was closed.

Change committed as 255785

Expand Messages | Collapse Messages