Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1904823003: Generate Android .isolate files used for test()s (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, mikecase+watch_chromium.org, android-webview-reviews_chromium.org, jbudorick+watch_chromium.org, bengr, dgn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate Android .isolate files used for test()s Tests use write_runtime_deps to have GN write out all runtime_deps, then use a new script "generate_isolate.py" to filter the files and create a .isolate. TBR=vollick BUG=589318 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/964da0f3923afb10a52dfe81484d7f3dcb18bad6 Cr-Commit-Position: refs/heads/master@{#389105}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : patched in junit fix for trybot #

Patch Set 4 : revert to PS2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -13 lines) Patch
M android_webview/test/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 2 chunks +3 lines, -1 line 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 2 chunks +3 lines, -1 line 0 comments Download
M build/android/pylib/utils/isolator.py View 1 chunk +6 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 3 chunks +3 lines, -3 lines 0 comments Download
M cc/BUILD.gn View 1 chunk +5 lines, -3 lines 0 comments Download
A testing/generate_isolate.py View 1 chunk +114 lines, -0 lines 0 comments Download
M testing/test.gni View 1 6 chunks +101 lines, -5 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904823003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904823003/20001
4 years, 8 months ago (2016-04-21 19:22:59 UTC) #3
agrieve
sgurun@chromium.org: Please review changes in android_webview/ vollick@chromium.org: Please review changes in cc/ dpranke@chromium.org: Please review ...
4 years, 8 months ago (2016-04-21 19:50:27 UTC) #6
Dirk Pranke
Do you actually need the junit changes, or are you actually landing patchset #2? lgtm ...
4 years, 8 months ago (2016-04-22 01:26:33 UTC) #7
agrieve
jochen@chromium.org: Please review changes in components/
4 years, 8 months ago (2016-04-22 01:38:21 UTC) #9
agrieve
On 2016/04/22 01:26:33, Dirk Pranke wrote: > Do you actually need the junit changes, or ...
4 years, 8 months ago (2016-04-22 01:39:09 UTC) #10
sgurun-gerrit only
On 2016/04/22 01:39:09, agrieve wrote: > On 2016/04/22 01:26:33, Dirk Pranke wrote: > > Do ...
4 years, 8 months ago (2016-04-22 02:32:13 UTC) #11
sgurun-gerrit only
On 2016/04/22 02:32:13, sgurun wrote: > On 2016/04/22 01:39:09, agrieve wrote: > > On 2016/04/22 ...
4 years, 8 months ago (2016-04-22 02:33:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904823003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904823003/60001
4 years, 8 months ago (2016-04-22 13:52:13 UTC) #16
agrieve
On 2016/04/22 13:52:13, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 8 months ago (2016-04-22 14:30:09 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-22 14:57:10 UTC) #19
apacible
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1911243004/ by apacible@chromium.org. ...
4 years, 8 months ago (2016-04-22 16:30:37 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:47:24 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/964da0f3923afb10a52dfe81484d7f3dcb18bad6
Cr-Commit-Position: refs/heads/master@{#389105}

Powered by Google App Engine
This is Rietveld 408576698