Reland of [tracing] Turn StackFrame into struct.

Reland of [tracing] Turn StackFrame into struct.

The original CL (1891543003) was reverted because it broke Windows x64 build:
heap_profiler_allocation_context.cc(58): warning C4267: 'argument': conversion
from 'size_t' to 'int', possible loss of data

This CL adds necessary cast to avoid the warning.

Original issue's description:
> [tracing] Turn StackFrame into struct.
>
> This change turns StackFrame (aka const char*) into a struct and
> introduces 'type' field which controls how stack frame is formatted
> when it's written to trace file. As an example, thread name, which
> previously was just a string like any other function name, is now
> formatted as '[Thread: %s]'.
>
> More stack frame types will be added in the future, for example
> native allocation tracing will add 'program counter' type.
>

BUG=602701
TBR=primiano@chromium.org

Committed: https://crrev.com/c4b751e78f505adc6316bae2d0ab111ba0218dce
Cr-Commit-Position: refs/heads/master@{#388615}

[Dmitry Skiba, 2016-04-20 21:49:59]

dskiba@google.com changed reviewers:
+ ssid@chromium.org

[Dmitry Skiba, 2016-04-20 21:49:59]

Please review.

[Dmitry Skiba, 2016-04-20 21:51:51]

Description was changed from

==========
Reland of [tracing] Turn StackFrame into struct.

The original CL (1891543003) was reverted because it broke Windows x64 build:
heap_profiler_allocation_context.cc(58): warning C4267: 'argument': conversion
from 'size_t' to 'int', possible loss of data

This CL adds necessary cast to avoid the warning.

Original issue's description:
> [tracing] Turn StackFrame into struct.
>
> This change turns StackFrame (aka const char*) into a struct and
> introduces 'type' field which controls how stack frame is formatted
> when it's written to trace file. As an example, thread name, which
> previously was just a string like any other function name, is now
> formatted as '[Thread: %s]'.
>
> More stack frame types will be added in the future, for example
> native allocation tracing will add 'program counter' type.
>
> BUG=602701
==========

to

==========
Reland of [tracing] Turn StackFrame into struct.

The original CL (1891543003) was reverted because it broke Windows x64 build:
heap_profiler_allocation_context.cc(58): warning C4267: 'argument': conversion
from 'size_t' to 'int', possible loss of data

This CL adds necessary cast to avoid the warning.

Original issue's description:
> [tracing] Turn StackFrame into struct.
>
> This change turns StackFrame (aka const char*) into a struct and
> introduces 'type' field which controls how stack frame is formatted
> when it's written to trace file. As an example, thread name, which
> previously was just a string like any other function name, is now
> formatted as '[Thread: %s]'.
>
> More stack frame types will be added in the future, for example
> native allocation tracing will add 'program counter' type.
>

BUG=602701
TBR=primiano@chromium.org
==========

[Dmitry Skiba, 2016-04-20 21:52:15]

dskiba@google.com changed reviewers:
+ primiano@chromium.org

[Dmitry Skiba, 2016-04-20 21:52:15]

+Primiano

[ssid, 2016-04-20 22:25:17]

lgtm

[Dmitry Skiba, 2016-04-20 22:26:31]

The CQ bit was checked by dskiba@google.com

[commit-bot: I haz the power, 2016-04-20 22:27:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904823002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904823002/20001

[commit-bot: I haz the power, 2016-04-21 00:10:07]

Description was changed from

==========
Reland of [tracing] Turn StackFrame into struct.

The original CL (1891543003) was reverted because it broke Windows x64 build:
heap_profiler_allocation_context.cc(58): warning C4267: 'argument': conversion
from 'size_t' to 'int', possible loss of data

This CL adds necessary cast to avoid the warning.

Original issue's description:
> [tracing] Turn StackFrame into struct.
>
> This change turns StackFrame (aka const char*) into a struct and
> introduces 'type' field which controls how stack frame is formatted
> when it's written to trace file. As an example, thread name, which
> previously was just a string like any other function name, is now
> formatted as '[Thread: %s]'.
>
> More stack frame types will be added in the future, for example
> native allocation tracing will add 'program counter' type.
>

BUG=602701
TBR=primiano@chromium.org
==========

to

==========
Reland of [tracing] Turn StackFrame into struct.

The original CL (1891543003) was reverted because it broke Windows x64 build:
heap_profiler_allocation_context.cc(58): warning C4267: 'argument': conversion
from 'size_t' to 'int', possible loss of data

This CL adds necessary cast to avoid the warning.

Original issue's description:
> [tracing] Turn StackFrame into struct.
>
> This change turns StackFrame (aka const char*) into a struct and
> introduces 'type' field which controls how stack frame is formatted
> when it's written to trace file. As an example, thread name, which
> previously was just a string like any other function name, is now
> formatted as '[Thread: %s]'.
>
> More stack frame types will be added in the future, for example
> native allocation tracing will add 'program counter' type.
>

BUG=602701
TBR=primiano@chromium.org
==========

[commit-bot: I haz the power, 2016-04-21 00:10:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:28:09]

Description was changed from

==========
Reland of [tracing] Turn StackFrame into struct.

The original CL (1891543003) was reverted because it broke Windows x64 build:
heap_profiler_allocation_context.cc(58): warning C4267: 'argument': conversion
from 'size_t' to 'int', possible loss of data

This CL adds necessary cast to avoid the warning.

Original issue's description:
> [tracing] Turn StackFrame into struct.
>
> This change turns StackFrame (aka const char*) into a struct and
> introduces 'type' field which controls how stack frame is formatted
> when it's written to trace file. As an example, thread name, which
> previously was just a string like any other function name, is now
> formatted as '[Thread: %s]'.
>
> More stack frame types will be added in the future, for example
> native allocation tracing will add 'program counter' type.
>

BUG=602701
TBR=primiano@chromium.org
==========

to

==========
Reland of [tracing] Turn StackFrame into struct.

The original CL (1891543003) was reverted because it broke Windows x64 build:
heap_profiler_allocation_context.cc(58): warning C4267: 'argument': conversion
from 'size_t' to 'int', possible loss of data

This CL adds necessary cast to avoid the warning.

Original issue's description:
> [tracing] Turn StackFrame into struct.
>
> This change turns StackFrame (aka const char*) into a struct and
> introduces 'type' field which controls how stack frame is formatted
> when it's written to trace file. As an example, thread name, which
> previously was just a string like any other function name, is now
> formatted as '[Thread: %s]'.
>
> More stack frame types will be added in the future, for example
> native allocation tracing will add 'program counter' type.
>

BUG=602701
TBR=primiano@chromium.org

Committed: https://crrev.com/c4b751e78f505adc6316bae2d0ab111ba0218dce
Cr-Commit-Position: refs/heads/master@{#388615}
==========

[commit-bot: I haz the power, 2016-04-22 19:28:10]

Patchset 2 (id:??) landed as
https://crrev.com/c4b751e78f505adc6316bae2d0ab111ba0218dce
Cr-Commit-Position: refs/heads/master@{#388615}