Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1904803002: MD Settings: Convert clear_browsing_data_dialog.html to use $i18n{}. (Closed)

Created:
4 years, 8 months ago by dpapad
Modified:
4 years, 8 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Convert clear_browsing_data_dialog.html to use $i18n{}. Committed: https://crrev.com/be08824bc590e337592cd9be3796c1c2217f5910 Cr-Commit-Position: refs/heads/master@{#388574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html View 2 chunks +17 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dpapad
Follow up from https://codereview.chromium.org/1902873003/diff/20001/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html#newcode68. Is there is an appropriate bug to attach to this CL?
4 years, 8 months ago (2016-04-20 19:09:37 UTC) #2
dschuyler
lgtm
4 years, 8 months ago (2016-04-20 20:46:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904803002/1
4 years, 8 months ago (2016-04-20 20:53:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 20:57:44 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:26:24 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/be08824bc590e337592cd9be3796c1c2217f5910
Cr-Commit-Position: refs/heads/master@{#388574}

Powered by Google App Engine
This is Rietveld 408576698