Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: media/test/pipeline_integration_test_base.h

Issue 1904793002: Move Pipeline permanent callbacks into Pipeline::Client interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: post stop callback Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/test/pipeline_integration_test.cc ('k') | media/test/pipeline_integration_test_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/test/pipeline_integration_test_base.h
diff --git a/media/test/pipeline_integration_test_base.h b/media/test/pipeline_integration_test_base.h
index 4205d166687aee90e3eb7c89684f31fcf330b4db..f23eace2c1b86a796e2435e9d88c520baa545518 100644
--- a/media/test/pipeline_integration_test_base.h
+++ b/media/test/pipeline_integration_test_base.h
@@ -59,7 +59,7 @@ class DummyTickClock : public base::TickClock {
// display or audio device. Both of these devices are simulated since they have
// little effect on verifying pipeline behavior and allow tests to run faster
// than real-time.
-class PipelineIntegrationTestBase {
+class PipelineIntegrationTestBase : public Pipeline::Client {
public:
PipelineIntegrationTestBase();
virtual ~PipelineIntegrationTestBase();
@@ -151,8 +151,6 @@ class PipelineIntegrationTestBase {
void DemuxerMediaTracksUpdatedCB(std::unique_ptr<MediaTracks> tracks);
- void OnEnded();
- void OnError(PipelineStatus status);
void QuitAfterCurrentTimeTask(const base::TimeDelta& quit_time);
// Creates Demuxer and sets |demuxer_|.
@@ -163,9 +161,13 @@ class PipelineIntegrationTestBase {
void OnVideoFramePaint(const scoped_refptr<VideoFrame>& frame);
- MOCK_METHOD1(OnMetadata, void(PipelineMetadata));
- MOCK_METHOD1(OnBufferingStateChanged, void(BufferingState));
MOCK_METHOD1(DecryptorAttached, void(bool));
+ // Pipeline::Client overrides.
+ void OnError(PipelineStatus status) override;
+ void OnEnded() override;
+ MOCK_METHOD1(OnMetadata, void(PipelineMetadata));
+ MOCK_METHOD1(OnBufferingStateChange, void(BufferingState));
+ MOCK_METHOD0(OnDurationChange, void());
MOCK_METHOD2(OnAddTextTrack,
void(const TextTrackConfig& config,
const AddTextTrackDoneCB& done_cb));
« no previous file with comments | « media/test/pipeline_integration_test.cc ('k') | media/test/pipeline_integration_test_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698