MenuButton: support Mac look & feel

ui/views/controls/button/menu_button.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/menu_button.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/base/dragdrop/drag_drop_types.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/base/ui_base_switches_util.h"
 #include "ui/events/event.h"
 #include "ui/events/event_constants.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/screen.h"
 #include "ui/gfx/text_constants.h"
 #include "ui/resources/grit/ui_resources.h"
 #include "ui/strings/grit/ui_strings.h"
 #include "ui/views/animation/ink_drop_delegate.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/controls/button/menu_button_listener.h"
+#include "ui/views/controls/focusable_border.h"

[tapted, 2016/04/26 05:05:57]

is this still needed?

[Elly Fong-Jones, 2016/04/26 17:41:25]

It seems to be needed so that the destructor can delete a
unique_ptr<FocusableBorder>.

[tapted, 2016/04/27 03:25:11]

Ah, that's subtle. I think we could have PlatformStyle::CreateMenuButtonBorder()
return a vanilla views::Border, but that might just require a border.h include
instead. So I think what you have is fine, but could go either way.

 #include "ui/views/mouse_constants.h"
 #include "ui/views/resources/grit/views_resources.h"
+#include "ui/views/style/platform_style.h"
 #include "ui/views/widget/root_view.h"
 #include "ui/views/widget/widget.h"
 
 using base::TimeTicks;
 using base::TimeDelta;
 
 namespace views {
 
 // Default menu offset.
 static const int kDefaultMenuOffsetX = -2;
@@ skipping 30 matching lines @@
 //
 ////////////////////////////////////////////////////////////////////////////////
 
 MenuButton::MenuButton(const base::string16& text,
                        MenuButtonListener* menu_button_listener,
                        bool show_menu_marker)
     : LabelButton(nullptr, text),
       menu_offset_(kDefaultMenuOffsetX, kDefaultMenuOffsetY),
       listener_(menu_button_listener),
       show_menu_marker_(show_menu_marker),
-      menu_marker_(ui::ResourceBundle::GetSharedInstance()
-                       .GetImageNamed(IDR_MENU_DROPARROW)
-                       .ToImageSkia()),
       destroyed_flag_(nullptr),
       pressed_lock_count_(0),
       increment_pressed_lock_called_(nullptr),
       should_disable_after_press_(false),
       weak_factory_(this) {
   SetHorizontalAlignment(gfx::ALIGN_LEFT);
+  SetBorder(PlatformStyle::CreateMenuButtonBorder());
+  if (show_menu_marker_) {
+    enabled_marker_image_ = PlatformStyle::CreateMenuButtonArrow(true);
+    disabled_marker_image_ = PlatformStyle::CreateMenuButtonArrow(false);
+    set_background(PlatformStyle::CreateMenuButtonBackground(GetShoulderWidth())
+                       .release());
+  }
 }
 
 MenuButton::~MenuButton() {
   if (destroyed_flag_)
     *destroyed_flag_ = true;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 //
 // MenuButton - Public APIs
@@ skipping 94 matching lines @@
   if (show_menu_marker_)
     PaintMenuMarker(canvas);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 //
 // MenuButton - Events
 //
 ////////////////////////////////////////////////////////////////////////////////
 
+int MenuButton::GetShoulderWidth() const {
+  const int kPadding = 7;
+  int marker_width = enabled() ? enabled_marker_image_.size().width()

[tapted, 2016/04/26 05:05:57]

nit: remove ".size()"

I think we can also do


if (!show_menu_marker_)
  return 0;

DCHECK_EQ(enabled_marker_image_.width(), disabled_marker_image_.width());
return enabled_marker_image_.width() + 2 * kPadding;



The early return means we can simplify GetPreferredSize() and
GetChildAreaBounds(), and the DCHECK simplifies things -- if it wasn't true,
we'd need to trigger a re-layout when the enable state changes, which I don't
think we do


[edit: that DCHECK will be unnecessary when we switch to just having one
ImageSkia]

[Elly Fong-Jones, 2016/04/26 17:41:25]

Done.

+                               : disabled_marker_image_.size().width();
+  return marker_width + 2 * kPadding;
+}
+
 gfx::Size MenuButton::GetPreferredSize() const {
   gfx::Size prefsize = LabelButton::GetPreferredSize();
-  if (show_menu_marker_) {
-    prefsize.Enlarge(menu_marker_->width() + kMenuMarkerPaddingLeft +
-                         kMenuMarkerPaddingRight,
-                     0);
-  }
+  if (show_menu_marker_)
+    prefsize.Enlarge(GetShoulderWidth(), 0);
   return prefsize;
 }
 
 const char* MenuButton::GetClassName() const {
   return kViewClassName;
 }
 
 bool MenuButton::OnMousePressed(const ui::MouseEvent& event) {
   if (request_focus_on_press())
     RequestFocus();
@@ skipping 93 matching lines @@
   state->role = ui::AX_ROLE_POP_UP_BUTTON;
   state->default_action = l10n_util::GetStringUTF16(IDS_APP_ACCACTION_PRESS);
   state->AddStateFlag(ui::AX_STATE_HASPOPUP);
 }
 
 void MenuButton::PaintMenuMarker(gfx::Canvas* canvas) {
   gfx::Insets insets = GetInsets();
 
   // Using the Views mirroring infrastructure incorrectly flips icon content.
   // Instead, manually mirror the position of the down arrow.
-  gfx::Rect arrow_bounds(width() - insets.right() -
-                         menu_marker_->width() - kMenuMarkerPaddingRight,
-                         height() / 2 - menu_marker_->height() / 2,
-                         menu_marker_->width(),
-                         menu_marker_->height());
+  gfx::Rect arrow_bounds(width() - insets.right() - GetShoulderWidth(), 0,
+                         GetShoulderWidth(), height());
+  gfx::ImageSkia marker =
+      enabled() ? enabled_marker_image_ : disabled_marker_image_;
+  arrow_bounds.ClampToCenteredSize(marker.size());
   arrow_bounds.set_x(GetMirroredXForRect(arrow_bounds));
-  canvas->DrawImageInt(*menu_marker_, arrow_bounds.x(), arrow_bounds.y());
+  canvas->DrawImageInt(marker, arrow_bounds.x(), arrow_bounds.y());
 }
 
 gfx::Rect MenuButton::GetChildAreaBounds() {
   gfx::Size s = size();
 
-  if (show_menu_marker_) {
-    s.set_width(s.width() - menu_marker_->width() - kMenuMarkerPaddingLeft -
-                kMenuMarkerPaddingRight);
-  }
+  if (show_menu_marker_)

[tapted, 2016/04/26 05:05:57]

not needed with the GetShoulderWidth() tweak. In fact the whole method can just
be

  return gfx::Rect(0, 0, width() - GetShoulderWidth(), height());

[Elly Fong-Jones, 2016/04/26 17:41:25]

Done.

+    s.set_width(s.width() - GetShoulderWidth());
 
   return gfx::Rect(s);
 }
 
 bool MenuButton::IsTriggerableEvent(const ui::Event& event) {
   if (!IsTriggerableEventType(event))
     return false;
 
   TimeDelta delta = TimeTicks::Now() - menu_closed_time_;
   if (delta.InMilliseconds() < kMinimumMsBetweenButtonClicks)
@@ skipping 64 matching lines @@
   if (!GetWidget()) {
     NOTREACHED();
     return 0;
   }
 
   gfx::Rect monitor_bounds = GetWidget()->GetWorkAreaBoundsInScreen();
   return monitor_bounds.right() - 1;
 }
 
 }  // namespace views