MenuButton: support Mac look & feel

ui/views/style/platform_style_mac.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/style/platform_style.h"
 
 #include "base/memory/ptr_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/paint_vector_icon.h"
 #include "ui/gfx/vector_icons.h"
@@ skipping 20 matching lines @@
     ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
     return *rb.GetImageSkiaNamed(IDR_MENU_DROPARROW);
   }
   const int kComboboxArrowWidth = 13;
   return gfx::CreateVectorIcon(gfx::VectorIconId::COMBOBOX_ARROW_MAC,
                                kComboboxArrowWidth,
                                is_enabled ? SK_ColorWHITE : SK_ColorBLACK);
 }
 
 // static
+gfx::ImageSkia PlatformStyle::CreateMenuButtonArrow(bool is_enabled) {
+  const int kComboboxArrowWidth = 13;

[tapted, 2016/04/21 06:06:46]

kMenuButtonArrowWidth

[Elly Fong-Jones, 2016/04/21 15:30:27]

Done.

+  return gfx::CreateVectorIcon(gfx::VectorIconId::MENU_BUTTON_ARROW_MAC,
+                               kComboboxArrowWidth,
+                               is_enabled ? SK_ColorWHITE : SK_ColorBLACK);
+}
+
+// static
 std::unique_ptr<FocusableBorder> PlatformStyle::CreateComboboxBorder() {
   return base::WrapUnique(new FocusableRoundedBorder);
 }
 
 // static
 std::unique_ptr<Background> PlatformStyle::CreateComboboxBackground() {
-  return base::WrapUnique(new ComboboxBackgroundMac);
+  return base::WrapUnique(
+      new ComboboxBackgroundMac(GetComboboxArrowWidth(Combobox::STYLE_NORMAL)));

[tapted, 2016/04/21 06:06:46]

comment above about why STYLE_NORMAL is right here?

[Elly Fong-Jones, 2016/04/21 15:30:27]

It's only okay because of an implementation detail of Combobox. I put a comment
to that effect.

 }
 
 // static
+std::unique_ptr<FocusableBorder> PlatformStyle::CreateMenuButtonBorder() {
+  return base::WrapUnique(new FocusableRoundedBorder);
+}
+
+// static
+std::unique_ptr<Background> PlatformStyle::CreateMenuButtonBackground() {
+  return base::WrapUnique(new ComboboxBackgroundMac(GetMenuButtonArrowWidth()));
+}
+
+// static
 std::unique_ptr<LabelButtonBorder> PlatformStyle::CreateLabelButtonBorder(
     Button::ButtonStyle style) {
   if (style == Button::STYLE_BUTTON)
     return base::WrapUnique(new DialogButtonBorderMac());
 
   return base::WrapUnique(new LabelButtonAssetBorder(style));
 }
 
 // static
 std::unique_ptr<ScrollBar> PlatformStyle::CreateScrollBar(bool is_horizontal) {
@@ skipping 18 matching lines @@
 void PlatformStyle::ApplyLabelButtonTextStyle(
     views::Label* label,
     ButtonColorByState* color_by_state) {
   const ui::NativeTheme* theme = label->GetNativeTheme();
   ButtonColorByState& colors = *color_by_state;
   colors[Button::STATE_PRESSED] =
       theme->GetSystemColor(ui::NativeTheme::kColorId_ButtonHighlightColor);
 }
 
 }  // namespace views