Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 190473002: Remove 'disable-cros-online-eula' cmd line flag (Closed)

Created:
6 years, 9 months ago by vasilii
Modified:
6 years, 9 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Remove 'disable-cros-online-eula' cmd line flag BUG=350323 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255675

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/browser/ui/webui/about_ui.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vasilii
Hi Nikita, please review the CL.
6 years, 9 months ago (2014-03-07 09:22:03 UTC) #1
Nikita (slow)
lgtm
6 years, 9 months ago (2014-03-07 09:23:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/190473002/1
6 years, 9 months ago (2014-03-07 09:25:53 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 15:33:36 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=277362
6 years, 9 months ago (2014-03-07 15:33:36 UTC) #5
vasilii
The CQ bit was checked by vasilii@chromium.org
6 years, 9 months ago (2014-03-07 15:51:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/190473002/1
6 years, 9 months ago (2014-03-07 15:51:23 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 19:09:07 UTC) #8
Message was sent while issue was closed. 
Change committed as 255675

Powered by Google App Engine
This is Rietveld 408576698