[wasm] Introduce ExecuteWasmCompilation and FinalizeWasmCompilation in pipeline.cc

src/compiler/pipeline.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_PIPELINE_H_
 #define V8_COMPILER_PIPELINE_H_
 
 // Clients of this interface shouldn't depend on lots of compiler internals.
 // Do not include anything from src/compiler here!
 #include "src/objects.h"
@@ skipping 45 matching lines @@
   // Run the pipeline on a machine graph and generate code. If {schedule} is
   // {nullptr}, then compute a new schedule for code generation.
   static Handle<Code> GenerateCodeForTesting(CompilationInfo* info,
                                              CallDescriptor* call_descriptor,
                                              Graph* graph,
                                              Schedule* schedule = nullptr);
 
   // Returns a new compilation job for the given compilation info.
   static OptimizedCompileJob* NewCompilationJob(CompilationInfo* info);
 
   void InitializeWasmCompilation(Zone* pipeline_zone, ZonePool* zone_pool,

[Michael Starzinger, 2016/04/20 16:59:08]

Not actionable for this CL, but I think we should really turn this into an
OptimizedCompileJob eventually. Maybe a TODO in that regard makes sense already.
WDYT?

                                  Graph* graph);
-  void FinalizeWasmCompilation();
+  bool ExecuteWasmCompilation(CallDescriptor* descriptor);
+  Handle<Code> FinalizeWasmCompilation(CallDescriptor* descriptor);
 
   Handle<Code> ScheduleAndGenerateCode(CallDescriptor* call_descriptor);

[Michael Starzinger, 2016/04/20 20:46:32]

Also, this seems to no longer be called from the outside, please make it private
again.

[ahaas, 2016/04/21 07:59:43]

Done.

 
  private:
   // Helpers for executing pipeline phases.
   template <typename Phase>
   void Run();
   template <typename Phase, typename Arg0>
   void Run(Arg0 arg_0);
   template <typename Phase, typename Arg0, typename Arg1>
   void Run(Arg0 arg_0, Arg1 arg_1);
 
   void BeginPhaseKind(const char* phase_kind);
   void RunPrintAndVerify(const char* phase, bool untyped = false);
   void AllocateRegisters(const RegisterConfiguration* config,
                          CallDescriptor* descriptor, bool run_verifier);
 
   CompilationInfo* info() const { return info_; }
   Isolate* isolate() const;
 
   CompilationInfo* const info_;
   PipelineData* data_;
 
   DISALLOW_COPY_AND_ASSIGN(Pipeline);
 };
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_PIPELINE_H_