Issue 19047003: Rebaseline bindings test results after r153938

Issue 19047003: Rebaseline bindings test results after r153938 (Closed)

Created:
7 years, 5 months ago by do-not-use

Modified:
7 years, 4 months ago

Reviewers:
haraken, arv (Not doing code reviews)

CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, do-not-use, lgombos

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Rebaseline bindings test results after r153938 Instead of passing an ExceptionCode (int) around to signify an exception, we now pass an ExceptionState object. R=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153986

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+118 lines, -183 lines)			Patch
M	Source/bindings/tests/results/V8Float64Array.cpp	View	2 chunks	+1 line, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestActiveDOMObject.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestCustomAccessors.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestEventTarget.cpp	View	5 chunks	+11 lines, -16 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestInterface.cpp	View	7 chunks	+16 lines, -26 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestMediaQueryListListener.cpp	View	2 chunks	+1 line, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestNamedConstructor.cpp	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestObject.cpp	View	21 chunks	+59 lines, -95 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestOverloadedConstructors.cpp	View	2 chunks	+1 line, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestTypedefs.cpp	View	9 chunks	+22 lines, -34 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/19047003/1

7 years, 5 months ago (2013-07-11 08:11:37 UTC) #3

arv (Not doing code reviews)

LGTM Thanks and I apologize. We should really add a presubmit check for this. If ...

7 years, 5 months ago (2013-07-11 14:01:00 UTC) #5

Nils Barth (inactive)

7 years, 4 months ago (2013-08-02 05:43:38 UTC) #6

Message was sent while issue was closed.

On 2013/07/11 14:01:00, arv wrote:
> LGTM
> 
> Thanks and I apologize. We should really add a presubmit check for this. If
> CodeGen is newer than test files prompt.

Ask, and you shall receive. See:
Issue 21722003: Add presubmit check for run-bindings-tests
https://codereview.chromium.org/21722003/

Expand Messages | Collapse Messages