Allow tests within WebKit to implicitly convert WebCString to std::string.

Allow tests within WebKit to implicitly convert WebCString to std::string.

Non-WebKit users can already do this.

BUG=172011
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154155

[Jeffrey Yasskin, 2013-07-11 06:53:27]

Adam suggested this in https://bugs.webkit.org/show_bug.cgi?id=110524#c23; it's
used at
https://codereview.chromium.org/18371008/diff/2001/Source/WebKit/chromium/tes....
It's possible that the Web* tests should compile as !INSIDE_WEBKIT instead?

[abarth-chromium, 2013-07-11 06:59:18]

On 2013/07/11 06:53:27, Jeffrey Yasskin wrote:
> It's possible that the Web* tests should compile as !INSIDE_WEBKIT instead?

Yeah, we should split the unit tests into those that are inside the DLL and
those that are outside the DLL.  Currently they run inside the DLL.  That's a
big project though.

This change makes some amount of sense for unit tests.  Maybe we should limit
the visibility to just unit tests somehow?

[Jeffrey Yasskin, 2013-07-11 07:05:24]

On Wed, Jul 10, 2013 at 11:59 PM,  <abarth@chromium.org> wrote:
> On 2013/07/11 06:53:27, Jeffrey Yasskin wrote:
>>
>> It's possible that the Web* tests should compile as !INSIDE_WEBKIT
>> instead?
>
>
> Yeah, we should split the unit tests into those that are inside the DLL and
> those that are outside the DLL.  Currently they run inside the DLL.  That's
> a
> big project though.

> This change makes some amount of sense for unit tests.  Maybe we should
> limit
> the visibility to just unit tests somehow?

Sounds fine to me. I'll look for a #define to check in the morning.

> https://codereview.chromium.org/19047002/

[Jeffrey Yasskin, 2013-07-11 20:32:40]

On 2013/07/11 07:05:24, Jeffrey Yasskin wrote:
> On Wed, Jul 10, 2013 at 11:59 PM,  <mailto:abarth@chromium.org> wrote:
> > This change makes some amount of sense for unit tests.  Maybe we should
> > limit
> > the visibility to just unit tests somehow?
> 
> Sounds fine to me. I'll look for a #define to check in the morning.

Found UNIT_TEST:
https://code.google.com/p/chromium/codesearch/#chromium/src/webkit/support/we...

https://codereview.chromium.org/19047002/diff/5629499534213120/public/platfor...
File public/platform/WebCString.h (right):

https://codereview.chromium.org/19047002/diff/5629499534213120/public/platfor...
public/platform/WebCString.h:99: WebCString(const std::string& s)
Defining these constructors in webkit tests causes an ambiguity for
WebCString("literal string"), so I left them out. operator string and fromUTF16
compiled fine.

[Jeffrey Yasskin, 2013-07-13 00:11:38]

Adam, I think you fell off of the cc list here somehow.

[abarth-chromium, 2013-07-13 00:14:05]

lgtm

[jamesr, 2013-07-13 00:14:12]

Could you update the patch description to say that this is only for unit tests,
if that's the case?

[commit-bot: I haz the power, 2013-07-13 00:14:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/19047002/5629499...

[jamesr, 2013-07-13 00:14:56]

(and lgtm)

[Jeffrey Yasskin, 2013-07-13 00:16:20]

On 2013/07/13 00:14:12, jamesr wrote:
> Could you update the patch description to say that this is only for unit
tests,
> if that's the case?

Good point. Done, and thanks for catching the bad CL description.

[commit-bot: I haz the power, 2013-07-13 00:17:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/19047002/5629499...

[commit-bot: I haz the power, 2013-07-13 01:46:38]

Change committed as 154155