Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1904673003: Rein in the use of SkDevice.h (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M bench/LightingBench.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M debugger/QT/SkGLWidget.h View 1 chunk +0 lines, -1 line 0 comments Download
M gm/beziereffects.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/bigrrectaaeffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/convexpolyeffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/extractbitmap.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/pathopsskpclip.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/rrects.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleAARectModes.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleAARects.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleCircle.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleClip.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleColorFilter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleHairModes.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleLCD.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleManyRects.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleSlides.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleStrokeRect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleTextAlpha.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/animator/SkSnapshot.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/ImageTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsSkpClipTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/SkpSkGrTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/debugger/SkDebugCanvas.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 8 months ago (2016-04-20 12:18:59 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904673003/1
4 years, 8 months ago (2016-04-20 12:19:07 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 12:28:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904673003/1
4 years, 8 months ago (2016-04-20 12:28:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/5e3815b4d074fe3c47bbf0969446ed9870e5ef0a
4 years, 8 months ago (2016-04-20 12:29:55 UTC) #12
reed1
4 years, 8 months ago (2016-04-20 13:27:27 UTC) #13
Message was sent while issue was closed. 
awesome!

Powered by Google App Engine
This is Rietveld 408576698