Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1904663006: Web Animations: Use camelCase for property name in performance test (Closed)

Created:
4 years, 8 months ago by Eric Willigers
Modified:
4 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Animations: Use camelCase for property name in performance test Hyphenated property names have been deprecated in the Web Animations API. BUG=595709 Committed: https://crrev.com/626255f1edd3892e60180f1004693e2e8c8cef63 Cr-Commit-Position: refs/heads/master@{#388712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M tools/perf/page_sets/tough_animation_cases/resources/css_value_type.js View 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Eric Willigers
4 years, 8 months ago (2016-04-21 00:26:25 UTC) #2
alancutter (OOO until 2018)
lgtm
4 years, 8 months ago (2016-04-21 02:43:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904663006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904663006/1
4 years, 8 months ago (2016-04-21 02:52:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/171207)
4 years, 8 months ago (2016-04-21 03:01:12 UTC) #7
Eric Willigers
+eakuefner for tools/perf OWNER review
4 years, 8 months ago (2016-04-21 03:27:16 UTC) #9
eakuefner
lgtm
4 years, 8 months ago (2016-04-21 07:08:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904663006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904663006/1
4 years, 8 months ago (2016-04-21 07:14:24 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 07:36:46 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:32:17 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/626255f1edd3892e60180f1004693e2e8c8cef63
Cr-Commit-Position: refs/heads/master@{#388712}

Powered by Google App Engine
This is Rietveld 408576698