Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 1904663003: [deoptimizer] Do not modify stack_fp which is used as a key for lookup of previously materialized o… (Closed)

Created:
4 years, 8 months ago by Igor Sheludko
Modified:
4 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Do not modify stack_fp which is used as a key for lookup of previously materialized objects. BUG=chromium:604680, v8:4698 LOG=N Committed: https://crrev.com/b4dbb2f710834f37a0e6fbc5ea7c6d660d25c8b0 Cr-Commit-Position: refs/heads/master@{#35693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -30 lines) Patch
M src/deoptimizer.cc View 9 chunks +21 lines, -25 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-604680.js View 2 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904663003/1
4 years, 8 months ago (2016-04-20 14:55:55 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 15:27:51 UTC) #5
Igor Sheludko
PTAL
4 years, 8 months ago (2016-04-21 07:55:50 UTC) #7
Jarin
lgtm. Thanks!
4 years, 8 months ago (2016-04-21 08:36:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904663003/1
4 years, 8 months ago (2016-04-21 09:51:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 09:53:16 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:22 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4dbb2f710834f37a0e6fbc5ea7c6d660d25c8b0
Cr-Commit-Position: refs/heads/master@{#35693}

Powered by Google App Engine
This is Rietveld 408576698