Remove document().page() null checks in MediaControls

Source/core/html/shadow/MediaControls.cpp

 /*
  * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 38 matching lines @@
     , m_toggleClosedCaptionsButton(0)
     , m_fullScreenButton(0)
     , m_durationDisplay(0)
     , m_enclosure(0)
     , m_hideFullscreenControlsTimer(this, &MediaControls::hideFullscreenControlsTimerFired)
     , m_isFullscreen(false)
     , m_isMouseOverControls(false)
 {
 }
 
 PassRefPtr<MediaControls> MediaControls::create(Document& document)

[eseidel, 2014/03/08 20:39:05]

One way to test these methods is to do:

<iframe id="iframe" src="about:blank">
<script>
var detachedDoc = iframe.contentDocument;
iframe.src ="whatever";
detachedDoc.tryToGrabAtMediaControlsStuff();
</script>

You may want to see if you can enter these codepaths that way before removing
these nullchecks.

 {
-    if (!document.page())
-        return nullptr;
-
     RefPtr<MediaControls> controls;
 #if OS(ANDROID)
     controls = adoptRef(new MediaControlsAndroid(document));
 #else
     controls = adoptRef(new MediaControls(document));
 #endif
 
     if (controls->initializeControls(document))
         return controls.release();
 
@@ skipping 86 matching lines @@
     m_muteButton->setMediaController(controller);
     m_volumeSlider->setMediaController(controller);
     m_toggleClosedCaptionsButton->setMediaController(controller);
     m_fullScreenButton->setMediaController(controller);
     m_durationDisplay->setMediaController(controller);
     m_enclosure->setMediaController(controller);
 }
 
 void MediaControls::reset()
 {
-    Page* page = document().page();
-    if (!page)
-        return;
-
     double duration = m_mediaController->duration();
     m_durationDisplay->setInnerText(RenderTheme::theme().formatMediaControlsTime(duration), ASSERT_NO_EXCEPTION);
     m_durationDisplay->setCurrentValue(duration);
 
     m_playButton->updateDisplayType();
 
     updateCurrentTimeDisplay();
 
     m_timeline->setDuration(m_mediaController->duration());
     m_timeline->setPosition(m_mediaController->currentTime());
@@ skipping 73 matching lines @@
     makeOpaque();
 
     stopHideFullscreenControlsTimer();
 }
 
 void MediaControls::updateCurrentTimeDisplay()
 {
     double now = m_mediaController->currentTime();
     double duration = m_mediaController->duration();
 
-    Page* page = document().page();
-    if (!page)
-        return;
-
     // After seek, hide duration display and show current time.
     if (now > 0) {
         m_currentTimeDisplay->show();
         m_durationDisplay->hide();
     }
 
     // Allow the theme to format the time.
     m_currentTimeDisplay->setInnerText(RenderTheme::theme().formatMediaControlsCurrentTime(now, duration), IGNORE_EXCEPTION);
     m_currentTimeDisplay->setCurrentValue(now);
 }
@@ skipping 95 matching lines @@
         return;
 
     makeTransparent();
 }
 
 void MediaControls::startHideFullscreenControlsTimer()
 {
     if (!m_isFullscreen)
         return;
 
-    Page* page = document().page();
-    if (!page)
-        return;
-
     m_hideFullscreenControlsTimer.startOneShot(timeWithoutMouseMovementBeforeHidingFullscreenControls);
 }
 
 void MediaControls::stopHideFullscreenControlsTimer()
 {
     m_hideFullscreenControlsTimer.stop();
 }
 
 const AtomicString& MediaControls::shadowPseudoId() const
 {
@@ skipping 46 matching lines @@
     m_textDisplayContainer->updateDisplay();
 }
 
 void MediaControls::insertTextTrackContainer(PassRefPtr<MediaControlTextTrackContainerElement> textTrackContainer)
 {
     // Insert it before the first controller element so it always displays behind the controls.
     insertBefore(textTrackContainer, m_enclosure);
 }
 
 }