Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1904623002: Precompilation: The root library may have no survivors if it just re-exports main. (Closed)

Created:
4 years, 8 months ago by rmacnak
Modified:
4 years, 8 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Precompilation: The root library may have no survivors if it just re-exports main. R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/6b91c5f11ba9a7a1624ff21478c8db4ecb731019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M runtime/vm/precompiler.cc View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 8 months ago (2016-04-20 00:35:37 UTC) #2
regis
LGTM
4 years, 8 months ago (2016-04-20 00:59:41 UTC) #3
rmacnak
4 years, 8 months ago (2016-04-20 18:29:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6b91c5f11ba9a7a1624ff21478c8db4ecb731019 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698