components/offline_pages/offline_page_model.h - Issue 1904613005: [Offline pages] Removing bookmarks dependency from offline pages component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_model.h

Issue 1904613005: [Offline pages] Removing bookmarks dependency from offline pages component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit tests compilation Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/offline_page_metadata_store_impl_unittest.cc ('k') | components/offline_pages/offline_page_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/offline_page_model.h

diff --git a/components/offline_pages/offline_page_model.h b/components/offline_pages/offline_page_model.h

index 6889df9d2823c45ec81e425052700fab459beba6..1cf601ec5feb8803cdf97975567c5dba816360e6 100644

--- a/components/offline_pages/offline_page_model.h

+++ b/components/offline_pages/offline_page_model.h

@@ -33,8 +33,8 @@ class TimeDelta;

namespace offline_pages {

-static const char* const BOOKMARK_NAMESPACE = "bookmark";

-static const int64_t INVALID_OFFLINE_ID = 0;

+static const char* const kBookmarkNamespace = "bookmark";

+static const int64_t kInvalidOfflineId = 0;

struct ClientId;