components/offline_pages/offline_page_metadata_store_impl.cc - Issue 1904613005: [Offline pages] Removing bookmarks dependency from offline pages component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_metadata_store_impl.cc

Issue 1904613005: [Offline pages] Removing bookmarks dependency from offline pages component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit tests compilation Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/offline_page_bookmark_bridge.cc ('k') | components/offline_pages/offline_page_metadata_store_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/offline_page_metadata_store_impl.cc

diff --git a/components/offline_pages/offline_page_metadata_store_impl.cc b/components/offline_pages/offline_page_metadata_store_impl.cc

index 7b96920b0c04f3f0abd8ca3c7f10aee9f0148599..ab508a1add8f857362d78812a9d0f7b8ac5e7751 100644

--- a/components/offline_pages/offline_page_metadata_store_impl.cc

+++ b/components/offline_pages/offline_page_metadata_store_impl.cc

@@ -174,7 +174,7 @@ void OfflinePageMetadataStoreImpl::LoadDone(

LOG(ERROR) << "unexpected entry missing bookmark id";

continue;

}

- item.client_id.name_space = offline_pages::BOOKMARK_NAMESPACE;

+ item.client_id.name_space = offline_pages::kBookmarkNamespace;

item.client_id.id = base::Int64ToString(entry.deprecated_bookmark_id());

OfflinePageEntry upgraded_entry;