Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6559)

Unified Diff: chrome/chrome_installer_static.gypi

Issue 1904613002: Preparation patch for moving the chrome crashpad integration into chrome_elf. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address sky's review comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_installer_static.gypi
diff --git a/chrome/chrome_installer_static.gypi b/chrome/chrome_installer_static.gypi
new file mode 100644
index 0000000000000000000000000000000000000000..636fc8c35effce3345a736356bb5139dff053361
--- /dev/null
+++ b/chrome/chrome_installer_static.gypi
@@ -0,0 +1,63 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+ 'target_defaults': {
+ 'variables': {
+ 'installer_static_target': 0,
+ },
+ 'target_conditions': [
+ # This part is shared between the two versions of the target.
robertshield 2016/04/20 17:32:50 Does there exist gyp magic such that only kernel32
ananta 2016/04/20 20:15:36 Done. Added comments here and in the build.gn file
+ ['installer_static_target==1', {
+ 'sources': [
+ 'install_static/install_util.h',
+ 'install_static/install_util.cc',
+ ],
+ 'include_dirs': [
+ '<(DEPTH)',
+ ],
+ }],
+ ],
+ },
+ 'conditions': [
+ ['OS=="win"', {
+ 'targets': [
+ {
+ # GN version: //chrome/install_static
+ 'target_name': 'install_static_util',
+ 'type': 'static_library',
+ 'variables': {
+ 'installer_static_target': 1,
+ },
+ 'dependencies': [
+ 'installer_util_strings',
+ '<(DEPTH)/base/base.gyp:base',
+ ],
+ },
+ ],
+ }],
+ ['OS=="win" and target_arch=="ia32"', {
+ 'targets': [
+ {
+ 'target_name': 'install_static_util_nacl_win64',
+ 'type': 'static_library',
+ 'variables': {
+ 'installer_static_target': 1,
+ },
+ 'dependencies': [
+ 'installer_util_strings',
+ ],
+ 'include_dirs': [
+ '<(SHARED_INTERMEDIATE_DIR)',
+ ],
+ 'configurations': {
+ 'Common_Base': {
+ 'msvs_target_platform': 'x64',
+ },
+ },
+ },
+ ],
+ }],
+ ],
+}

Powered by Google App Engine
This is Rietveld 408576698