Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3599)

Unified Diff: chrome/app/chrome_crash_reporter_client.h

Issue 1904613002: Preparation patch for moving the chrome crashpad integration into chrome_elf. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add chrome_installer_static.gypi Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/chrome_crash_reporter_client.h
diff --git a/chrome/app/chrome_crash_reporter_client.h b/chrome/app/chrome_crash_reporter_client.h
index 4d184861175fdbffa51c485f8cb410e2e64fb8aa..e76fcb95742d2e609dc2b80f87df721c9335118e 100644
--- a/chrome/app/chrome_crash_reporter_client.h
+++ b/chrome/app/chrome_crash_reporter_client.h
@@ -24,30 +24,10 @@ class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
~ChromeCrashReporterClient() override;
// crash_reporter::CrashReporterClient implementation.
-#if !defined(OS_MACOSX) && !defined(OS_WIN)
+#if !defined(OS_MACOSX)
void SetCrashReporterClientIdFromGUID(
const std::string& client_guid) override;
#endif
-#if defined(OS_WIN)
- bool GetAlternativeCrashDumpLocation(base::FilePath* crash_dir) override;
- void GetProductNameAndVersion(const base::FilePath& exe_path,
- base::string16* product_name,
- base::string16* version,
- base::string16* special_build,
- base::string16* channel_name) override;
- bool ShouldShowRestartDialog(base::string16* title,
- base::string16* message,
- bool* is_rtl_locale) override;
- bool AboutToRestart() override;
- bool GetDeferredUploadsSupported(bool is_per_user_install) override;
- bool GetIsPerUserInstall(const base::FilePath& exe_path) override;
- bool GetShouldDumpLargerDumps(bool is_per_user_install) override;
- int GetResultCodeRespawnFailed() override;
- void InitBrowserCrashDumpsRegKey() override;
- void RecordCrashDumpAttempt(bool is_real_crash) override;
- void RecordCrashDumpAttemptResult(bool is_real_crash,
- bool succeeded) override;
-#endif
#if defined(OS_POSIX) && !defined(OS_MACOSX)
void GetProductNameAndVersion(const char** product_name,
@@ -63,7 +43,7 @@ class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
bool GetCollectStatsConsent() override;
-#if defined(OS_WIN) || defined(OS_MACOSX)
+#if defined(OS_MACOSX)
bool ReportingIsEnforcedByPolicy(bool* breakpad_enabled) override;
#endif
@@ -74,11 +54,6 @@ class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
bool EnableBreakpadForProcess(const std::string& process_type) override;
private:
-#if defined(OS_WIN)
- std::unique_ptr<browser_watcher::CrashReportingMetrics>
- crash_reporting_metrics_;
-#endif
-
DISALLOW_COPY_AND_ASSIGN(ChromeCrashReporterClient);
};

Powered by Google App Engine
This is Rietveld 408576698