build_overrides/README.md - Issue 1904563002: Standalone GN build.

Unified Diff: build_overrides/README.md

Issue 1904563002: Standalone GN build. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Index: build_overrides/README.md

diff --git a/build_overrides/README.md b/build_overrides/README.md

new file mode 100644

index 0000000000000000000000000000000000000000..4b2c71dd555128a31cd2f48f5183f970e558cba4

--- /dev/null

+++ b/build_overrides/README.md

@@ -0,0 +1,29 @@

+# Build overrides in GN

+This directory is used to allow different products to customize settings

+for repos that are DEPS'ed in or shared.

+For example: V8 could be built on its own (in a "standalone" configuration),

Tom Sepez 2016/04/19 21:45:09 Nit: might prefer "can" over "could" and adjust gr

dsinclair 2016/04/20 13:19:39 Done.

+and it could be built as part of Chromium. V8 might define a top-level

Tom Sepez 2016/04/19 21:45:09 s/might define/defines/

dsinclair 2016/04/20 13:19:39 Done.

+target, //v8:d8 (a simple executable), that should only be built in the

+standalone configuration. To figure out whether or not it should be

Tom Sepez 2016/04/19 21:45:09 To indicate that it is a standalone configuation

dsinclair 2016/04/20 13:19:38 Done.

+in a standalone configuration, v8 can create a file, build_overrides/v8.gni,

+that contains a variable, `build_standalone_d8 = true`.

+and import it (as import("//build_overrides/v8.gni") from its top-level

+BUILD.gn file.

+Chromium, on the other hand, might not need to build d8, and so it would

Tom Sepez 2016/04/19 21:45:09 s/might not/does not/

dsinclair 2016/04/20 13:19:38 Done.

+create its own build_overrides/v8.gni file, and in it set

+`build_standalone_d8 = false`.

+The two files should define the same set of variables, but the values can

Tom Sepez 2016/04/19 21:45:09 should vs. must ?

dsinclair 2016/04/20 13:19:39 Sounds like it isn't required (this file is copied

+vary as appropriate to the needs of the two different builds.

Tom Sepez 2016/04/19 21:45:09 to suit the needs

dsinclair 2016/04/20 13:19:38 Done.

+The build.gni file provides a way for projects to override defaults for

+variables used in //build itself (which we want to be shareable between

+projects).

+TODO(crbug.com/588513): Ideally //build_overrides and, in particular,

+//build_overrides/build.gni should go away completely in favor of some

+mechanism that can re-use other required files like //.gn, so that we don't

+have to keep requiring projects to create a bunch of different files to use GN.

« DEPS ('K') | « build_gyp/standalone.gypi ('k') | build_overrides/build.gni » ('j') | core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp » ('J')