Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(485)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: build_overrides/v8.gni
Issue
1904563002
:
Standalone GN build. (Closed)
Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set:
Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
.gitignore
.gn
BUILD.gn
DEPS
build_gyp/gyp_pdfium
build_gyp/standalone.gypi
build_overrides/README.md
build_overrides/build.gni
build_overrides/v8.gni
core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp
core/fxcrt/fx_basic_wstring.cpp
core/fxcrt/include/fx_string.h
pdfium.gni
samples/BUILD.gn
testing/multiprocess_func_list.h
testing/multiprocess_func_list.cc
testing/test.gni
third_party/BUILD.gn
third_party/pymock/LICENSE.txt
third_party/pymock/OWNERS
third_party/pymock/README.chromium
third_party/pymock/mock.py
View unified diff
|
Download patch
« no previous file with comments
|
« build_overrides/build.gni
('k') |
core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
# Copyright 2015 The Chromium Authors. All rights reserved.
2
# Use of this source code is governed by a BSD-style license that can be
3
# found in the LICENSE file.
4
5
if (is_android) {
6
import("//build/config/android/config.gni")
7
}
8
9
v8_use_external_startup_data = false
10
11
# V8 extras
12
# Adding V8 extras files requires API owners review
13
# Be sure to synchronize with build/common.gypi
14
15
v8_extra_library_files = []
16
v8_experimental_extra_library_files = []
OLD
NEW
« no previous file with comments
|
« build_overrides/build.gni
('k') |
core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp »
('j') |
no next file with comments »
Issue 1904563002: Standalone GN build. (Closed)
Created 4 years, 8 months ago by dsinclair
Modified 4 years, 8 months ago
Reviewers: Tom Sepez, Lei Zhang, Nico, Wei Li
Base URL: https://pdfium.googlesource.com/pdfium.git@master
Comments: 20
This is Rietveld
408576698
Chromium Code Reviews
Issue 1904563002:
Standalone GN build. (Closed)
Base URL: https://pdfium.googlesource.com/pdfium.git@master