build_overrides/README.md - Issue 1904563002: Standalone GN build.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build_overrides/README.md

Issue 1904563002: Standalone GN build. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Build overrides in GN

	2

	3 This directory is used to allow different products to customize settings

	4 for repos that are DEPS'ed in or shared.

	5

	6 For example: V8 could be built on its own (in a "standalone" configuration),
	Tom Sepez 2016/04/19 21:45:09 Nit: might prefer "can" over "could" and adjust gr Nit: might prefer "can" over "could" and adjust grammar all the way down. dsinclair 2016/04/20 13:19:39 Done. Show quoted text On 2016/04/19 21:45:09, Tom Sepez wrote: > Nit: might prefer "can" over "could" and adjust grammar all the way down. Done.
	7 and it could be built as part of Chromium. V8 might define a top-level
	Tom Sepez 2016/04/19 21:45:09 s/might define/defines/ s/might define/defines/ dsinclair 2016/04/20 13:19:39 Done. Show quoted text On 2016/04/19 21:45:09, Tom Sepez wrote: > s/might define/defines/ Done.
	8 target, //v8:d8 (a simple executable), that should only be built in the

	9 standalone configuration. To figure out whether or not it should be
	Tom Sepez 2016/04/19 21:45:09 To indicate that it is a standalone configuation To indicate that it is a standalone configuation dsinclair 2016/04/20 13:19:38 Done. Show quoted text On 2016/04/19 21:45:09, Tom Sepez wrote: > To indicate that it is a standalone configuation Done.
	10 in a standalone configuration, v8 can create a file, build_overrides/v8.gni,

	11 that contains a variable, `build_standalone_d8 = true`.

	12 and import it (as import("//build_overrides/v8.gni") from its top-level

	13 BUILD.gn file.

	14

	15 Chromium, on the other hand, might not need to build d8, and so it would
	Tom Sepez 2016/04/19 21:45:09 s/might not/does not/ s/might not/does not/ dsinclair 2016/04/20 13:19:38 Done. Show quoted text On 2016/04/19 21:45:09, Tom Sepez wrote: > s/might not/does not/ Done.
	16 create its own build_overrides/v8.gni file, and in it set

	17 `build_standalone_d8 = false`.

	18

	19 The two files should define the same set of variables, but the values can
	Tom Sepez 2016/04/19 21:45:09 should vs. must ? should vs. must ? dsinclair 2016/04/20 13:19:39 Sounds like it isn't required (this file is copied Show quoted text On 2016/04/19 21:45:09, Tom Sepez wrote: > should vs. must ? Sounds like it isn't required (this file is copied from chromium originally)
	20 vary as appropriate to the needs of the two different builds.
	Tom Sepez 2016/04/19 21:45:09 to suit the needs to suit the needs dsinclair 2016/04/20 13:19:38 Done. Show quoted text On 2016/04/19 21:45:09, Tom Sepez wrote: > to suit the needs Done.
	21

	22 The build.gni file provides a way for projects to override defaults for

	23 variables used in //build itself (which we want to be shareable between

	24 projects).

	25

	26 TODO(crbug.com/588513): Ideally //build_overrides and, in particular,

	27 //build_overrides/build.gni should go away completely in favor of some

	28 mechanism that can re-use other required files like //.gn, so that we don't

	29 have to keep requiring projects to create a bunch of different files to use GN.

OLD	NEW

« DEPS ('K') | « build_gyp/standalone.gypi ('k') | build_overrides/build.gni » ('j') | core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp » ('J')