Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1213)

Unified Diff: sdk/lib/io/directory_impl.dart

Issue 1904553006: Fix strong mode errors in dart:io. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address comment.~ Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/io/directory_impl.dart
diff --git a/sdk/lib/io/directory_impl.dart b/sdk/lib/io/directory_impl.dart
index d76b86d83988a29832475e51735a738733f44390..52cf54824ecf4e8ed14a4b5491ade076c4a32471 100644
--- a/sdk/lib/io/directory_impl.dart
+++ b/sdk/lib/io/directory_impl.dart
@@ -22,7 +22,9 @@ class _Directory extends FileSystemEntity implements Directory {
external static _create(String path);
external static _deleteNative(String path, bool recursive);
external static _rename(String path, String newPath);
- external static List _list(String path, bool recursive, bool followLinks);
+ external static void _fillWithDirectoryListing(
+ List<FileSystemEntity> list, String path, bool recursive,
+ bool followLinks);
static Directory get current {
var result = _current();
@@ -222,14 +224,18 @@ class _Directory extends FileSystemEntity implements Directory {
followLinks).stream;
}
- List listSync({bool recursive: false, bool followLinks: true}) {
+ List<FileSystemEntity> listSync(
+ {bool recursive: false, bool followLinks: true}) {
if (recursive is! bool || followLinks is! bool) {
throw new ArgumentError();
}
- return _list(
+ var result = <FileSystemEntity>[];
+ _fillWithDirectoryListing(
+ result,
FileSystemEntity._ensureTrailingPathSeparators(path),
recursive,
followLinks);
+ return result;
}
String toString() => "Directory: '$path'";

Powered by Google App Engine
This is Rietveld 408576698