Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 1904553004: VM: Split GYP build target 'runtime' to speedup SDK build times. (Closed)

Created:
4 years, 8 months ago by Florian Schneider
Modified:
4 years, 8 months ago
Reviewers:
rmacnak, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Bill Hesse
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Split GYP build target 'runtime' to speedup SDK build times. This speeds up a regular full 'runtime' build on my Linux box by around 40% by avoiding to build the precompiled runtime by default (measured user-time) 'runtime_precompiled' also builds 35% faster than 'runtime' before. BUG= R=iposva@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/9ff22315d88aadc6ebfc93757f2131ecd23aa383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M dart.gyp View 1 chunk +28 lines, -1 line 0 comments Download
M runtime/dart-runtime.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Florian Schneider
4 years, 8 months ago (2016-04-20 14:55:07 UTC) #2
Ivan Posva
Please announce these changes to the VM team, so they are not surprised if a ...
4 years, 8 months ago (2016-04-20 21:15:48 UTC) #3
rmacnak
lgtm Bill, this will require an update of the precompilation bots' build step to tools/build.py ...
4 years, 8 months ago (2016-04-20 22:39:26 UTC) #4
Florian Schneider
4 years, 8 months ago (2016-04-21 09:40:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9ff22315d88aadc6ebfc93757f2131ecd23aa383.

Powered by Google App Engine
This is Rietveld 408576698