Check IPC messages for banned types on Linux and Android.

Check IPC messages for banned types on Android.

This change enables check-ipc option for find-bad-constructs Clang
plugin on Android. With that option Clang plugin will check that the
following types are not used in IPC messages:

1. Types: long / unsigned long (but not typedefs to)
2. Typedefs: intmax_t, uintmax_t, intptr_t, uintptr_t, wint_t, size_t,
   rsize_t, ssize_t, ptrdiff_t, dev_t, off_t, clock_t, time_t, suseconds_t
   (including typedefs to)
3. Any template referencing the above (e.g. std::vector<size_t>)

These types are banned because they are not stable across 32/64-bit platforms.

BUG=581409
Committed: https://crrev.com/972c22efaddb8a541351329c9e7609d04d75b95f
Cr-Commit-Position: refs/heads/master@{#389850}

[Dmitry Skiba, 2016-04-19 20:55:29]

dskiba@google.com changed reviewers:
+ dpranke@chromium.org

[Dmitry Skiba, 2016-04-19 20:55:29]

Please review.

[Dirk Pranke, 2016-04-19 21:37:39]

dpranke@chromium.org changed reviewers:
+ thakis@chromium.org

[Dirk Pranke, 2016-04-19 21:37:40]

this seems basically okay to me, but it might be better to have thakis@ approve
this as he's probably more familiar with this plugin.

[Dmitry Skiba, 2016-04-25 15:21:29]

Nico: PTAL

Note that I had to disable running this on Linux because I couldn't find a way
to exclude chromecast - is_chromecast is defined too late, and is not available
in clang/BUILD.gn (the only failed bot failed for some other reason)

[Dmitry Skiba, 2016-04-25 15:23:22]

Description was changed from

==========
Check IPC messages for banned types on Linux and Android.

This change enables check-ipc option for find-bad-constructs Clang
plugin on both Linux and Android. With that option Clang plugin will
check that the following types are not used in IPC messages:

1. Types: long / unsigned long (but not typedefs to)
2. Typedefs: intmax_t, uintmax_t, intptr_t, uintptr_t, wint_t, size_t,
   rsize_t, ssize_t, ptrdiff_t, dev_t, off_t, clock_t, time_t, suseconds_t
   (including typedefs to)
3. Any template referencing the above (e.g. std::vector<size_t>)

These types are banned because they are not stable across 32/64-bit platforms.

BUG=581409
==========

to

==========
Check IPC messages for banned types on Android.

This change enables check-ipc option for find-bad-constructs Clang
plugin on Android. With that option Clang plugin will check that the
following types are not used in IPC messages:

1. Types: long / unsigned long (but not typedefs to)
2. Typedefs: intmax_t, uintmax_t, intptr_t, uintptr_t, wint_t, size_t,
   rsize_t, ssize_t, ptrdiff_t, dev_t, off_t, clock_t, time_t, suseconds_t
   (including typedefs to)
3. Any template referencing the above (e.g. std::vector<size_t>)

These types are banned because they are not stable across 32/64-bit platforms.

BUG=581409
==========

[Nico, 2016-04-25 15:23:53]

lgtm, but we don't build many configurations with clang on android (i think only
asan builds?) -- so maybe it might make sense to figure out what it takes to
enable this on linux too.

[Dmitry Skiba, 2016-04-25 18:12:23]

On 2016/04/25 15:23:53, Nico wrote:
> lgtm, but we don't build many configurations with clang on android (i think
only
> asan builds?) -- so maybe it might make sense to figure out what it takes to
> enable this on linux too.

PTAL again. I used (defined(is_chromecast) && is_chromecast) trick, and now we
run this check on Linux too.

[Dirk Pranke, 2016-04-25 18:41:42]

https://codereview.chromium.org/1904553002/diff/100001/build/config/clang/BUI...
File build/config/clang/BUILD.gn (right):

https://codereview.chromium.org/1904553002/diff/100001/build/config/clang/BUI...
build/config/clang/BUILD.gn:54: !(defined(is_chromecast) && is_chromecast)) {
import("//build/config/chromecast_build.gni") up after line 5, and you can refer
to is_chromecast directly. What you're doing here is extremely dodgy instead :).

[Dmitry Skiba, 2016-04-26 17:11:39]

On 2016/04/25 18:41:42, Dirk Pranke wrote:
>
https://codereview.chromium.org/1904553002/diff/100001/build/config/clang/BUI...
> File build/config/clang/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1904553002/diff/100001/build/config/clang/BUI...
> build/config/clang/BUILD.gn:54: !(defined(is_chromecast) && is_chromecast)) {
> import("//build/config/chromecast_build.gni") up after line 5, and you can
refer
> to is_chromecast directly. What you're doing here is extremely dodgy instead
:).

Thanks Dirk! It definitely looks better now.

Guys, PTAL?

[Dirk Pranke, 2016-04-26 18:30:54]

lgtm

[Dmitry Skiba, 2016-04-26 18:39:58]

The CQ bit was checked by dskiba@google.com

[Dmitry Skiba, 2016-04-26 18:39:58]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1904553002/#ps120001
(title: "Use import, remove defined() hack")

[commit-bot: I haz the power, 2016-04-26 18:40:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904553002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904553002/120001

[commit-bot: I haz the power, 2016-04-26 19:34:29]

Description was changed from

==========
Check IPC messages for banned types on Android.

This change enables check-ipc option for find-bad-constructs Clang
plugin on Android. With that option Clang plugin will check that the
following types are not used in IPC messages:

1. Types: long / unsigned long (but not typedefs to)
2. Typedefs: intmax_t, uintmax_t, intptr_t, uintptr_t, wint_t, size_t,
   rsize_t, ssize_t, ptrdiff_t, dev_t, off_t, clock_t, time_t, suseconds_t
   (including typedefs to)
3. Any template referencing the above (e.g. std::vector<size_t>)

These types are banned because they are not stable across 32/64-bit platforms.

BUG=581409
==========

to

==========
Check IPC messages for banned types on Android.

This change enables check-ipc option for find-bad-constructs Clang
plugin on Android. With that option Clang plugin will check that the
following types are not used in IPC messages:

1. Types: long / unsigned long (but not typedefs to)
2. Typedefs: intmax_t, uintmax_t, intptr_t, uintptr_t, wint_t, size_t,
   rsize_t, ssize_t, ptrdiff_t, dev_t, off_t, clock_t, time_t, suseconds_t
   (including typedefs to)
3. Any template referencing the above (e.g. std::vector<size_t>)

These types are banned because they are not stable across 32/64-bit platforms.

BUG=581409
==========

[commit-bot: I haz the power, 2016-04-26 19:34:30]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-04-26 19:36:54]

Description was changed from

==========
Check IPC messages for banned types on Android.

This change enables check-ipc option for find-bad-constructs Clang
plugin on Android. With that option Clang plugin will check that the
following types are not used in IPC messages:

1. Types: long / unsigned long (but not typedefs to)
2. Typedefs: intmax_t, uintmax_t, intptr_t, uintptr_t, wint_t, size_t,
   rsize_t, ssize_t, ptrdiff_t, dev_t, off_t, clock_t, time_t, suseconds_t
   (including typedefs to)
3. Any template referencing the above (e.g. std::vector<size_t>)

These types are banned because they are not stable across 32/64-bit platforms.

BUG=581409
==========

to

==========
Check IPC messages for banned types on Android.

This change enables check-ipc option for find-bad-constructs Clang
plugin on Android. With that option Clang plugin will check that the
following types are not used in IPC messages:

1. Types: long / unsigned long (but not typedefs to)
2. Typedefs: intmax_t, uintmax_t, intptr_t, uintptr_t, wint_t, size_t,
   rsize_t, ssize_t, ptrdiff_t, dev_t, off_t, clock_t, time_t, suseconds_t
   (including typedefs to)
3. Any template referencing the above (e.g. std::vector<size_t>)

These types are banned because they are not stable across 32/64-bit platforms.

BUG=581409

Committed: https://crrev.com/972c22efaddb8a541351329c9e7609d04d75b95f
Cr-Commit-Position: refs/heads/master@{#389850}
==========

[commit-bot: I haz the power, 2016-04-26 19:36:55]

Patchset 7 (id:??) landed as
https://crrev.com/972c22efaddb8a541351329c9e7609d04d75b95f
Cr-Commit-Position: refs/heads/master@{#389850}