Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1904543002: Implement FunctionElementForLink_FunctionTypedParam.parameters. (Closed)

Created:
4 years, 8 months ago by Paul Berry
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement FunctionElementForLink_FunctionTypedParam.parameters. This required some refactoring so that (a) we share code between FunctionElementForLink_FunctionTypedParam and ExecutableElementForLink, and (b) we compute the proper implicitFunctionTypeIndices for deeply nested parameters. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/60e37b99f93ccf44fb9938042856a26fb3f9e6fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -52 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 14 chunks +85 lines, -40 lines 0 comments Download
M pkg/analyzer/test/src/summary/linker_test.dart View 3 chunks +43 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 8 months ago (2016-04-19 20:48:45 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-04-19 21:01:19 UTC) #3
Paul Berry
4 years, 8 months ago (2016-04-19 21:22:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
60e37b99f93ccf44fb9938042856a26fb3f9e6fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698