Componentize PasswordManager and PasswordFormManager unittests.

Componentize PasswordManager and PasswordFormManager unittests.

The changes involved are straightforward.

BUG=348522, 348517
R=vabr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255576

[blundell, 2014-03-07 09:10:44]

The style churn is the result of using "git cl format".

[vabr (Chromium), 2014-03-07 09:38:09]

LGTM with one optional nit. Thanks!

(Also, good to get the style fixed through the files!)

Cheers,
Vaclav

https://codereview.chromium.org/190453002/diff/1/components/password_manager/...
File components/password_manager/core/browser/password_manager_unittest.cc
(right):

https://codereview.chromium.org/190453002/diff/1/components/password_manager/...
components/password_manager/core/browser/password_manager_unittest.cc:210:
scoped_ptr<TestPasswordManager> manager_;
nit: You can also get rid of the scoped_ptr and include the manager as a member,
because we no longer need to destroy the manager during TearDown().

[blundell, 2014-03-07 09:44:52]

https://codereview.chromium.org/190453002/diff/1/components/password_manager/...
File components/password_manager/core/browser/password_manager_unittest.cc
(right):

https://codereview.chromium.org/190453002/diff/1/components/password_manager/...
components/password_manager/core/browser/password_manager_unittest.cc:210:
scoped_ptr<TestPasswordManager> manager_;
This isn't actually (easily) doable, as the PasswordManager requires that the
kPasswordManagerEnabled pref be already registered on its construction.

On 2014/03/07 09:38:09, vabr (Chromium) wrote:
> nit: You can also get rid of the scoped_ptr and include the manager as a
member,
> because we no longer need to destroy the manager during TearDown().

[vabr (Chromium), 2014-03-07 09:46:35]

LGTM

https://codereview.chromium.org/190453002/diff/1/components/password_manager/...
File components/password_manager/core/browser/password_manager_unittest.cc
(right):

https://codereview.chromium.org/190453002/diff/1/components/password_manager/...
components/password_manager/core/browser/password_manager_unittest.cc:210:
scoped_ptr<TestPasswordManager> manager_;
On 2014/03/07 09:44:53, blundell wrote:
> This isn't actually (easily) doable, as the PasswordManager requires that the
> kPasswordManagerEnabled pref be already registered on its construction.
> 
> On 2014/03/07 09:38:09, vabr (Chromium) wrote:
> > nit: You can also get rid of the scoped_ptr and include the manager as a
> member,
> > because we no longer need to destroy the manager during TearDown().
> 

Ah, good point. Let's keep it as scoped_ptr then.

[blundell, 2014-03-07 10:39:24]

Committed patchset #1 manually as r255576 (presubmit successful).