Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: appengine/logdog/coordinator/endpoints/logs/get_test.go

Issue 1904503003: LogDog: Fix archived log stream read errors. (Closed) Base URL: https://github.com/luci/luci-go@hierarchy-check-first
Patch Set: Delete "offset()" method. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/logdog/coordinator/endpoints/logs/get.go ('k') | common/gcloud/gs/gs.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/logdog/coordinator/endpoints/logs/get_test.go
diff --git a/appengine/logdog/coordinator/endpoints/logs/get_test.go b/appengine/logdog/coordinator/endpoints/logs/get_test.go
index 3fa8c80b62eba3048ccb7befc2d5ffbd86f573df..b37e77b7b9bd7ed051ed7b52ce475f85a5ab6874 100644
--- a/appengine/logdog/coordinator/endpoints/logs/get_test.go
+++ b/appengine/logdog/coordinator/endpoints/logs/get_test.go
@@ -9,6 +9,7 @@ import (
"errors"
"fmt"
"io"
+ "math"
"testing"
"time"
@@ -64,7 +65,7 @@ func (c testGSClient) NewWriter(gs.Path) (gs.Writer, error) {
func (c testGSClient) Rename(gs.Path, gs.Path) error { return errors.New("not implemented") }
func (c testGSClient) Delete(gs.Path) error { return errors.New("not implemented") }
-func (c testGSClient) NewReader(path gs.Path, o gs.Options) (io.ReadCloser, error) {
+func (c testGSClient) NewReader(path gs.Path, offset int64, length int64) (io.ReadCloser, error) {
if d, ok := c["error"]; ok {
return nil, errors.New(string(d))
}
@@ -74,11 +75,17 @@ func (c testGSClient) NewReader(path gs.Path, o gs.Options) (io.ReadCloser, erro
return nil, errors.New("does not exist")
}
- to := int(o.To)
- if to == 0 {
- to = len(d)
+ // Determine the slice of data to return.
+ if offset < 0 {
+ offset = 0
}
- d = d[int(o.From):to]
+ end := int64(len(d))
+ if length >= 0 {
+ if v := offset + length; v < end {
+ end = v
+ }
+ }
+ d = d[offset:end]
r := make([]byte, len(d))
copy(r, d)
@@ -141,10 +148,8 @@ func zeroRecords(d []byte) {
}
}
-func TestGet(t *testing.T) {
- t.Parallel()
-
- Convey(`With a testing configuration, a Get request`, t, func() {
+func testGetImpl(t *testing.T, archived bool) {
+ Convey(fmt.Sprintf(`With a testing configuration, a Get request (archived=%v)`, archived), t, func() {
c, tc := testclock.UseTime(context.Background(), testclock.TestTimeLocal)
c = memory.Use(c)
@@ -213,6 +218,20 @@ func TestGet(t *testing.T) {
protobufs[uint64(v)] = d
}
+ // frameSize returns the full RecordIO frame size for the named log protobuf
+ // indices.
+ frameSize := func(indices ...uint64) int32 {
+ var size int
+ for _, idx := range indices {
+ pb := protobufs[idx]
+ size += recordio.FrameHeaderSize(int64(len(pb))) + len(pb)
+ }
+ if size > math.MaxInt32 {
+ panic(size)
+ }
+ return int32(size)
+ }
+
Convey(`Testing Get requests (no logs)`, func() {
req := logdog.GetRequest{
Path: string(ls.Path()),
@@ -239,341 +258,341 @@ func TestGet(t *testing.T) {
})
})
- for _, v := range []bool{
- false,
- true,
- } {
- is := "is"
- if !v {
- is += " not"
+ if !archived {
+ // Add the logs to the in-memory temporary storage.
+ for _, le := range entries {
+ err := ms.Put(storage.PutRequest{
+ Path: ls.Path(),
+ Index: types.MessageIndex(le.StreamIndex),
+ Values: [][]byte{protobufs[le.StreamIndex]},
+ })
+ if err != nil {
+ panic(fmt.Errorf("failed to Put() LogEntry: %v", err))
+ }
+ }
+ } else {
+ // Archive this log stream. We will generate one index entry for every
+ // 2 log entries.
+ src := staticArchiveSource(entries)
+ var lbuf, ibuf bytes.Buffer
+ m := archive.Manifest{
+ Desc: desc,
+ Source: &src,
+ LogWriter: &lbuf,
+ IndexWriter: &ibuf,
+ StreamIndexRange: 2,
+ }
+ if err := archive.Archive(m); err != nil {
+ panic(err)
}
- Convey(fmt.Sprintf(`When the log %s archived`, is), func() {
- if !v {
- // Add the logs to the in-memory temporary storage.
- for _, le := range entries {
- err := ms.Put(storage.PutRequest{
- Path: ls.Path(),
- Index: types.MessageIndex(le.StreamIndex),
- Values: [][]byte{protobufs[le.StreamIndex]},
- })
- if err != nil {
- panic(fmt.Errorf("failed to Put() LogEntry: %v", err))
- }
- }
- } else {
- // Archive this log stream. We will generate one index entry for every
- // 2 log entries.
- src := staticArchiveSource(entries)
- var lbuf, ibuf bytes.Buffer
- m := archive.Manifest{
- Desc: desc,
- Source: &src,
- LogWriter: &lbuf,
- IndexWriter: &ibuf,
- StreamIndexRange: 2,
- }
- if err := archive.Archive(m); err != nil {
- panic(err)
- }
+ now := tc.Now().UTC()
+
+ gsc.put("gs://testbucket/stream", lbuf.Bytes())
+ gsc.put("gs://testbucket/index", ibuf.Bytes())
+ ls.State = coordinator.LSArchived
+ ls.TerminatedTime = now
+ ls.ArchivedTime = now
+ ls.ArchiveStreamURL = "gs://testbucket/stream"
+ ls.ArchiveIndexURL = "gs://testbucket/index"
+ }
+ if err := ds.Get(c).Put(ls); err != nil {
+ panic(err)
+ }
- now := tc.Now().UTC()
+ Convey(`Testing Get requests`, func() {
+ req := logdog.GetRequest{
+ Path: string(ls.Path()),
+ }
- gsc.put("gs://testbucket/stream", lbuf.Bytes())
- gsc.put("gs://testbucket/index", ibuf.Bytes())
- ls.State = coordinator.LSArchived
- ls.TerminatedTime = now
- ls.ArchivedTime = now
- ls.ArchiveStreamURL = "gs://testbucket/stream"
- ls.ArchiveIndexURL = "gs://testbucket/index"
- }
+ Convey(`When the log stream is purged`, func() {
+ ls.Purged = true
if err := ds.Get(c).Put(ls); err != nil {
panic(err)
}
- Convey(`Testing Get requests`, func() {
- req := logdog.GetRequest{
- Path: string(ls.Path()),
- }
+ Convey(`Will return NotFound if the user is not an administrator.`, func() {
+ _, err := s.Get(c, &req)
+ So(err, ShouldBeRPCNotFound)
+ })
- Convey(`When the log stream is purged`, func() {
- ls.Purged = true
- if err := ds.Get(c).Put(ls); err != nil {
- panic(err)
- }
+ Convey(`Will process the request if the user is an administrator.`, func() {
+ fs.IdentityGroups = []string{"test-administrators"}
- Convey(`Will return NotFound if the user is not an administrator.`, func() {
- _, err := s.Get(c, &req)
- So(err, ShouldBeRPCNotFound)
- })
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 0, 1, 2)
+ })
+ })
- Convey(`Will process the request if the user is an administrator.`, func() {
- fs.IdentityGroups = []string{"test-administrators"}
+ Convey(`Will return empty if no records were requested.`, func() {
+ req.LogCount = -1
+ req.State = false
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 0, 1, 2)
- })
- })
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp.Logs, ShouldHaveLength, 0)
+ })
- Convey(`Will return empty if no records were requested.`, func() {
- req.LogCount = -1
- req.State = false
+ Convey(`Will successfully retrieve a stream path.`, func() {
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 0, 1, 2)
+ })
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp.Logs, ShouldHaveLength, 0)
- })
+ Convey(`Will successfully retrieve a stream path offset at 4.`, func() {
+ req.Index = 4
- Convey(`Will successfully retrieve a stream path.`, func() {
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 0, 1, 2)
- })
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 4, 5)
+ })
- Convey(`Will successfully retrieve a stream path offset at 4.`, func() {
- req.Index = 4
+ Convey(`Will retrieve no logs for contiguous offset 6.`, func() {
+ req.Index = 6
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 4, 5)
- })
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(len(resp.Logs), ShouldEqual, 0)
+ })
- Convey(`Will retrieve no logs for contiguous offset 6.`, func() {
- req.Index = 6
+ Convey(`Will retrieve log 7 for non-contiguous offset 6.`, func() {
+ req.NonContiguous = true
+ req.Index = 6
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(len(resp.Logs), ShouldEqual, 0)
- })
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 7)
+ })
- Convey(`Will retrieve log 7 for non-contiguous offset 6.`, func() {
- req.NonContiguous = true
- req.Index = 6
+ Convey(`With a byte limit of 1, will still return at least one log entry.`, func() {
+ req.ByteCount = 1
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 7)
- })
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 0)
+ })
- Convey(`With a byte limit of 1, will still return at least one log entry.`, func() {
- req.ByteCount = 1
+ Convey(`With a byte limit of sizeof(0), will return log entry 0.`, func() {
+ req.ByteCount = frameSize(0)
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 0)
- })
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 0)
+ })
- Convey(`With a byte limit of sizeof(0), will return log entry 0.`, func() {
- req.ByteCount = int32(len(protobufs[0]))
+ Convey(`With a byte limit of sizeof(0)+1, will return log entry 0.`, func() {
+ req.ByteCount = frameSize(0) + 1
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 0)
- })
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 0)
+ })
- Convey(`With a byte limit of sizeof(0)+1, will return log entry 0.`, func() {
- req.ByteCount = int32(len(protobufs[0]))
+ Convey(`With a byte limit of sizeof({0, 1}), will return log entries {0, 1}.`, func() {
+ req.ByteCount = frameSize(0, 1)
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 0)
- })
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 0, 1)
+ })
- Convey(`With a byte limit of sizeof({0, 1}), will return log entries {0, 1}.`, func() {
- req.ByteCount = int32(len(protobufs[0]) + len(protobufs[1]))
+ Convey(`With a byte limit of sizeof({0, 1, 2}), will return log entries {0, 1, 2}.`, func() {
+ req.ByteCount = frameSize(0, 1, 2)
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 0, 1)
- })
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 0, 1, 2)
+ })
- Convey(`With a byte limit of sizeof({0, 1, 2}), will return log entries {0, 1, 2}.`, func() {
- req.ByteCount = int32(len(protobufs[0]) + len(protobufs[1]) + len(protobufs[2]))
+ Convey(`With a byte limit of sizeof({0, 1, 2})+1, will return log entries {0, 1, 2}.`, func() {
+ req.ByteCount = frameSize(0, 1, 2) + 1
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 0, 1, 2)
- })
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 0, 1, 2)
+ })
- Convey(`With a byte limit of sizeof({0, 1, 2})+1, will return log entries {0, 1, 2}.`, func() {
- req.ByteCount = int32(len(protobufs[0]) + len(protobufs[1]) + len(protobufs[2]) + 1)
+ Convey(`Will successfully retrieve a stream path hash.`, func() {
+ req.Path = ls.HashID
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 0, 1, 2)
+ })
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 0, 1, 2)
- })
+ Convey(`When requesting state`, func() {
+ req.State = true
+ req.LogCount = -1
- Convey(`Will successfully retrieve a stream path hash.`, func() {
- req.Path = ls.HashID
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 0, 1, 2)
- })
+ Convey(`Will successfully retrieve stream state.`, func() {
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp.State, ShouldResemble, loadLogStreamState(ls))
+ So(len(resp.Logs), ShouldEqual, 0)
+ })
- Convey(`When requesting state`, func() {
- req.State = true
- req.LogCount = -1
-
- Convey(`Will successfully retrieve stream state.`, func() {
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp.State, ShouldResemble, loadLogStreamState(ls))
- So(len(resp.Logs), ShouldEqual, 0)
- })
-
- Convey(`Will return Internal if the protobuf descriptor data is corrupt.`, func() {
- ls.SetDSValidate(false)
- ls.Descriptor = []byte{0x00} // Invalid protobuf, zero tag.
- if err := ds.Get(c).Put(ls); err != nil {
- panic(err)
- }
-
- _, err := s.Get(c, &req)
- So(err, ShouldBeRPCInternal)
- })
- })
+ Convey(`Will return Internal if the protobuf descriptor data is corrupt.`, func() {
+ ls.SetDSValidate(false)
+ ls.Descriptor = []byte{0x00} // Invalid protobuf, zero tag.
+ if err := ds.Get(c).Put(ls); err != nil {
+ panic(err)
+ }
- Convey(`Will return Internal if the protobuf log entry data is corrupt.`, func() {
- if v {
- // Corrupt the archive datastream.
- stream := gsc.get("gs://testbucket/stream")
- zeroRecords(stream)
- } else {
- // Add corrupted entry to Storage. Create a new entry here, since
- // the storage will reject a duplicate/overwrite.
- err := ms.Put(storage.PutRequest{
- Path: types.StreamPath(req.Path),
- Index: 666,
- Values: [][]byte{{0x00}}, // Invalid protobuf, zero tag.
- })
- if err != nil {
- panic(err)
- }
- req.Index = 666
- }
-
- _, err := s.Get(c, &req)
- So(err, ShouldBeRPCInternal)
+ _, err := s.Get(c, &req)
+ So(err, ShouldBeRPCInternal)
+ })
+ })
+
+ Convey(`Will return Internal if the protobuf log entry data is corrupt.`, func() {
+ if archived {
+ // Corrupt the archive datastream.
+ stream := gsc.get("gs://testbucket/stream")
+ zeroRecords(stream)
+ } else {
+ // Add corrupted entry to Storage. Create a new entry here, since
+ // the storage will reject a duplicate/overwrite.
+ err := ms.Put(storage.PutRequest{
+ Path: types.StreamPath(req.Path),
+ Index: 666,
+ Values: [][]byte{{0x00}}, // Invalid protobuf, zero tag.
})
+ if err != nil {
+ panic(err)
+ }
+ req.Index = 666
+ }
- Convey(`Will successfully retrieve both logs and stream state.`, func() {
- req.State = true
+ _, err := s.Get(c, &req)
+ So(err, ShouldBeRPCInternal)
+ })
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp.State, ShouldResemble, loadLogStreamState(ls))
- So(resp, shouldHaveLogs, 0, 1, 2)
- })
+ Convey(`Will successfully retrieve both logs and stream state.`, func() {
+ req.State = true
- Convey(`Will return Internal if the Storage is not working.`, func() {
- if v {
- gsc["error"] = []byte("test error")
- } else {
- ms.Close()
- }
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp.State, ShouldResemble, loadLogStreamState(ls))
+ So(resp, shouldHaveLogs, 0, 1, 2)
+ })
- _, err := s.Get(c, &req)
- So(err, ShouldBeRPCInternal)
- })
+ Convey(`Will return Internal if the Storage is not working.`, func() {
+ if archived {
+ gsc["error"] = []byte("test error")
+ } else {
+ ms.Close()
+ }
- Convey(`Will enforce a maximum count of 2.`, func() {
- req.LogCount = 2
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 0, 1)
- })
+ _, err := s.Get(c, &req)
+ So(err, ShouldBeRPCInternal)
+ })
- Convey(`When requesting protobufs`, func() {
- req.State = true
+ Convey(`Will enforce a maximum count of 2.`, func() {
+ req.LogCount = 2
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 0, 1)
+ })
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 0, 1, 2)
+ Convey(`When requesting protobufs`, func() {
+ req.State = true
- // Confirm that this has protobufs.
- So(len(resp.Logs), ShouldEqual, 3)
- So(resp.Logs[0], ShouldNotBeNil)
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 0, 1, 2)
- // Confirm that there is a descriptor protobuf.
- So(resp.Desc, ShouldResemble, desc)
+ // Confirm that this has protobufs.
+ So(len(resp.Logs), ShouldEqual, 3)
+ So(resp.Logs[0], ShouldNotBeNil)
- // Confirm that the state was returned.
- So(resp.State, ShouldNotBeNil)
- })
+ // Confirm that there is a descriptor protobuf.
+ So(resp.Desc, ShouldResemble, desc)
- Convey(`Will successfully retrieve all records if non-contiguous is allowed.`, func() {
- req.NonContiguous = true
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 0, 1, 2, 4, 5, 7)
- })
+ // Confirm that the state was returned.
+ So(resp.State, ShouldNotBeNil)
+ })
- Convey(`When newlines are not requested, does not include delimiters.`, func() {
- req.LogCount = 1
+ Convey(`Will successfully retrieve all records if non-contiguous is allowed.`, func() {
+ req.NonContiguous = true
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 0, 1, 2, 4, 5, 7)
+ })
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 0)
+ Convey(`When newlines are not requested, does not include delimiters.`, func() {
+ req.LogCount = 1
- So(resp.Logs[0].GetText(), ShouldResemble, &logpb.Text{
- Lines: []*logpb.Text_Line{
- {"log entry #0", "\n"},
- {"another line of text", ""},
- },
- })
- })
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 0)
- Convey(`Will get a Binary LogEntry`, func() {
- req.Index = 4
- req.LogCount = 1
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 4)
- So(resp.Logs[0].GetBinary(), ShouldResemble, &logpb.Binary{
- Data: []byte{0x00, 0x01, 0x02, 0x03},
- })
- })
+ So(resp.Logs[0].GetText(), ShouldResemble, &logpb.Text{
+ Lines: []*logpb.Text_Line{
+ {"log entry #0", "\n"},
+ {"another line of text", ""},
+ },
+ })
+ })
- Convey(`Will get a Datagram LogEntry`, func() {
- req.Index = 5
- req.LogCount = 1
- resp, err := s.Get(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 5)
- So(resp.Logs[0].GetDatagram(), ShouldResemble, &logpb.Datagram{
- Data: []byte{0x00, 0x01, 0x02, 0x03},
- Partial: &logpb.Datagram_Partial{
- Index: 2,
- Size: 1024,
- Last: false,
- },
- })
- })
+ Convey(`Will get a Binary LogEntry`, func() {
+ req.Index = 4
+ req.LogCount = 1
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 4)
+ So(resp.Logs[0].GetBinary(), ShouldResemble, &logpb.Binary{
+ Data: []byte{0x00, 0x01, 0x02, 0x03},
})
+ })
- Convey(`Testing tail requests`, func() {
- req := logdog.TailRequest{
- Path: string(ls.Path()),
- }
+ Convey(`Will get a Datagram LogEntry`, func() {
+ req.Index = 5
+ req.LogCount = 1
+ resp, err := s.Get(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 5)
+ So(resp.Logs[0].GetDatagram(), ShouldResemble, &logpb.Datagram{
+ Data: []byte{0x00, 0x01, 0x02, 0x03},
+ Partial: &logpb.Datagram_Partial{
+ Index: 2,
+ Size: 1024,
+ Last: false,
+ },
+ })
+ })
+ })
- Convey(`Will successfully retrieve a stream path.`, func() {
- resp, err := s.Tail(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 7)
- })
+ Convey(`Testing tail requests`, func() {
+ req := logdog.TailRequest{
+ Path: string(ls.Path()),
+ }
- Convey(`Will successfully retrieve a stream path hash and state.`, func() {
- req.Path = ls.HashID
- req.State = true
+ Convey(`Will successfully retrieve a stream path.`, func() {
+ resp, err := s.Tail(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 7)
+ })
- resp, err := s.Tail(c, &req)
- So(err, ShouldBeRPCOK)
- So(resp, shouldHaveLogs, 7)
- So(resp.State, ShouldResemble, loadLogStreamState(ls))
- })
- })
+ Convey(`Will successfully retrieve a stream path hash and state.`, func() {
+ req.Path = ls.HashID
+ req.State = true
+
+ resp, err := s.Tail(c, &req)
+ So(err, ShouldBeRPCOK)
+ So(resp, shouldHaveLogs, 7)
+ So(resp.State, ShouldResemble, loadLogStreamState(ls))
})
- }
+ })
})
}
+
+func TestGetIntermediate(t *testing.T) {
+ t.Parallel()
+
+ testGetImpl(t, false)
+}
+
+func TestGetArchived(t *testing.T) {
+ t.Parallel()
+
+ testGetImpl(t, true)
+}
« no previous file with comments | « appengine/logdog/coordinator/endpoints/logs/get.go ('k') | common/gcloud/gs/gs.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698