Element's insertAdjacent API should lazy attach

Element's insertAdjacent API should lazy attach

insertAdjacentElement, insertAdjacentText and insertAdjacentHTML should all lazyAttach
just like appendChild() would have.

I also removed some redundant ASSERT_WITH_SECURITY_IMPLICATIONS that aren't needed
since we use toElement() right below them which contains the same assert.

R=ojan@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154094

[ojan, 2013-07-12 05:12:43]

https://codereview.chromium.org/19045003/diff/1/Source/core/html/HTMLElement.cpp
File Source/core/html/HTMLElement.cpp (left):

https://codereview.chromium.org/19045003/diff/1/Source/core/html/HTMLElement....
Source/core/html/HTMLElement.cpp:540:
ASSERT_WITH_SECURITY_IMPLICATION(!returnValue || returnValue->isElementNode());
What's wrong with these asserts?

[esprehn, 2013-07-12 05:56:42]

On 2013/07/12 05:12:43, ojan wrote:
>
https://codereview.chromium.org/19045003/diff/1/Source/core/html/HTMLElement.cpp
> File Source/core/html/HTMLElement.cpp (left):
> 
>
https://codereview.chromium.org/19045003/diff/1/Source/core/html/HTMLElement....
> Source/core/html/HTMLElement.cpp:540:
> ASSERT_WITH_SECURITY_IMPLICATION(!returnValue ||
returnValue->isElementNode());
> What's wrong with these asserts?

You don't need them, the toElement() call below those lines has that inside it.

[ojan, 2013-07-12 06:15:28]

> You don't need them, the toElement() call below those lines has that inside
it.

Add this to the change description?

[ojan, 2013-07-12 06:15:34]

lgtm

[commit-bot: I haz the power, 2013-07-12 06:21:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/19045003/1

[commit-bot: I haz the power, 2013-07-12 06:46:45]

Retried try job too often on linux_layout_rel for step(s) webkit_python_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-07-12 07:26:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/19045003/1

[esprehn, 2013-07-12 07:37:16]

Committed patchset #1 manually as r154094 (presubmit successful).