Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2372)

Unified Diff: chrome/common/extensions/api/declarative_content.json

Issue 19045002: Use Blink support to watch CSS selectors directly instead of using a MutationObserver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: unCamelCase in Chrome code. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_renderer.gypi ('k') | chrome/renderer/extensions/content_watcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/declarative_content.json
diff --git a/chrome/common/extensions/api/declarative_content.json b/chrome/common/extensions/api/declarative_content.json
index bed20fcb4f298241bc8558f8077f98c30462aa5a..13d302b14511b71400e17b82ef5e2cdafb2bc4c2 100644
--- a/chrome/common/extensions/api/declarative_content.json
+++ b/chrome/common/extensions/api/declarative_content.json
@@ -21,16 +21,12 @@
"css": {
"type": "array",
"optional": true,
- "description": "Matches if all of the CSS selectors in the array match in a frame with the same origin as the page's main frame. Note that listing hundreds of CSS selectors here can slow down web sites.",
+ "description": "Matches if all of the CSS selectors in the array match in a frame with the same origin as the page's main frame. Note that listing hundreds of CSS selectors or CSS selectors that match hundreds of times per page can slow down web sites.",
// TODO(jyasskin): Figure out if we want to require all
// the selectors to match in the same frame, or allow several
// frames to contribute to a match.
"items": { "type": "string" }
- // TODO(jyasskin): Validate that the selectors in this
- // array are valid. Otherwise, we can get exceptions from
- // content_watcher.js:FindMatchingSelectors() long after the
- // rule is registered.
-// },
+// },
// TODO: "text": {
// "type": "array",
// "optional": true,
« no previous file with comments | « chrome/chrome_renderer.gypi ('k') | chrome/renderer/extensions/content_watcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698