Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: net/spdy/spdy_network_transaction_unittest.cc

Issue 1904483004: Change SupportsSpdy dict, SpdySettingsMap, ServerNetworkStatsMap, AlternativeServiceMap and disk da… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl format net Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_network_transaction_unittest.cc
diff --git a/net/spdy/spdy_network_transaction_unittest.cc b/net/spdy/spdy_network_transaction_unittest.cc
index 67d97f82522530ec11219ea497a31df9930198f7..3ded16972907fa7760a39cb15d07a9d382aa4b5a 100644
--- a/net/spdy/spdy_network_transaction_unittest.cc
+++ b/net/spdy/spdy_network_transaction_unittest.cc
@@ -110,7 +110,7 @@ void UpdateSpdySessionDependencies(SpdyNetworkTransactionTestParams test_params,
if (test_params.ssl_type == HTTP_SPDY_VIA_ALT_SVC) {
base::Time expiration = base::Time::Now() + base::TimeDelta::FromDays(1);
session_deps->http_server_properties.SetAlternativeService(
- HostPortPair("www.example.org", 80),
+ url::SchemeHostPort("http", "www.example.org", 80),
AlternativeService(AlternateProtocolFromNextProto(test_params.protocol),
"www.example.org", 443),
expiration);
@@ -4230,9 +4230,13 @@ TEST_P(SpdyNetworkTransactionTest, SettingsSaved) {
// Verify that no settings exist initially.
HostPortPair host_port_pair("www.example.org", helper.port());
+ url::SchemeHostPort spdy_server("https", host_port_pair.host(),
+ host_port_pair.port());
+
SpdySessionPool* spdy_session_pool = helper.session()->spdy_session_pool();
- EXPECT_TRUE(spdy_session_pool->http_server_properties()->GetSpdySettings(
- host_port_pair).empty());
+ EXPECT_TRUE(spdy_session_pool->http_server_properties()
+ ->GetSpdySettings(spdy_server)
+ .empty());
// Construct the request.
std::unique_ptr<SpdySerializedFrame> req(
@@ -4290,7 +4294,7 @@ TEST_P(SpdyNetworkTransactionTest, SettingsSaved) {
// Verify we had two persisted settings.
const SettingsMap& settings_map =
spdy_session_pool->http_server_properties()->GetSpdySettings(
- host_port_pair);
+ spdy_server);
ASSERT_EQ(2u, settings_map.size());
// Verify the first persisted setting.
@@ -4341,8 +4345,11 @@ TEST_P(SpdyNetworkTransactionTest, SettingsPlayback) {
// Verify that no settings exist initially.
HostPortPair host_port_pair("www.example.org", helper.port());
- EXPECT_TRUE(spdy_session_pool->http_server_properties()->GetSpdySettings(
- host_port_pair).empty());
+ url::SchemeHostPort spdy_server("https", host_port_pair.host(),
+ host_port_pair.port());
+ EXPECT_TRUE(spdy_session_pool->http_server_properties()
+ ->GetSpdySettings(spdy_server)
+ .empty());
const SpdySettingsIds kSampleId1 = SETTINGS_MAX_CONCURRENT_STREAMS;
unsigned int kSampleValue1 = 0x0a0a0a0a;
@@ -4351,20 +4358,15 @@ TEST_P(SpdyNetworkTransactionTest, SettingsPlayback) {
// First add a persisted setting.
spdy_session_pool->http_server_properties()->SetSpdySetting(
- host_port_pair,
- kSampleId1,
- SETTINGS_FLAG_PLEASE_PERSIST,
- kSampleValue1);
+ spdy_server, kSampleId1, SETTINGS_FLAG_PLEASE_PERSIST, kSampleValue1);
// Next add another persisted setting.
spdy_session_pool->http_server_properties()->SetSpdySetting(
- host_port_pair,
- kSampleId2,
- SETTINGS_FLAG_PLEASE_PERSIST,
- kSampleValue2);
+ spdy_server, kSampleId2, SETTINGS_FLAG_PLEASE_PERSIST, kSampleValue2);
- EXPECT_EQ(2u, spdy_session_pool->http_server_properties()->GetSpdySettings(
- host_port_pair).size());
+ EXPECT_EQ(2u, spdy_session_pool->http_server_properties()
+ ->GetSpdySettings(spdy_server)
+ .size());
// Construct the initial SETTINGS frame.
SettingsMap initial_settings;
@@ -4375,8 +4377,7 @@ TEST_P(SpdyNetworkTransactionTest, SettingsPlayback) {
// Construct the persisted SETTINGS frame.
const SettingsMap& settings =
- spdy_session_pool->http_server_properties()->GetSpdySettings(
- host_port_pair);
+ spdy_session_pool->http_server_properties()->GetSpdySettings(spdy_server);
std::unique_ptr<SpdySerializedFrame> settings_frame(
spdy_util_.ConstructSpdySettings(settings));
@@ -4418,7 +4419,7 @@ TEST_P(SpdyNetworkTransactionTest, SettingsPlayback) {
// Verify we had two persisted settings.
const SettingsMap& settings_map =
spdy_session_pool->http_server_properties()->GetSpdySettings(
- host_port_pair);
+ spdy_server);
ASSERT_EQ(2u, settings_map.size());
// Verify the first persisted setting.

Powered by Google App Engine
This is Rietveld 408576698