Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1904473003: Re-enable warning 4701 for GN (re-land) (Closed)

Created:
4 years, 8 months ago by Wei Li
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Re-enable warning 4701 for GN (re-land) Remove one left warning from GN Release build. Committed: https://pdfium.googlesource.com/pdfium/+/b67e566ed29b7115ceaca18aad046f1784435730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfdoc/doc_form.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Wei Li
PTAL, thanks
4 years, 8 months ago (2016-04-19 18:25:02 UTC) #2
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-19 18:33:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904473003/1
4 years, 8 months ago (2016-04-19 22:32:17 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 22:50:33 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/b67e566ed29b7115ceaca18aad046f178443...

Powered by Google App Engine
This is Rietveld 408576698