Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1904473002: Add arflags to GN (Closed)

Created:
4 years, 8 months ago by brettw
Modified:
4 years, 8 months ago
Reviewers:
brucedawson
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add arflags to GN Allows the build to specify flags to the static library archiver tool. BUG=598599 Committed: https://crrev.com/440b117bb10d5c7e195a26cf974ccbd5886948b0 Cr-Commit-Position: refs/heads/master@{#388315}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -4 lines) Patch
M tools/gn/config_values.h View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/gn/config_values_generator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/docs/reference.md View 1 3 chunks +40 lines, -0 lines 0 comments Download
M tools/gn/function_toolchain.cc View 4 chunks +10 lines, -2 lines 0 comments Download
M tools/gn/ninja_binary_target_writer.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M tools/gn/ninja_binary_target_writer_unittest.cc View 3 chunks +34 lines, -0 lines 0 comments Download
M tools/gn/substitution_type.h View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/gn/substitution_type.cc View 3 chunks +13 lines, -0 lines 0 comments Download
M tools/gn/variables.h View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/gn/variables.cc View 2 chunks +20 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1896163003 Patch 1

Messages

Total messages: 13 (5 generated)
brettw
.
4 years, 8 months ago (2016-04-19 17:26:45 UTC) #1
brettw
After this rolls https://codereview.chromium.org/1896163003/ will update the toolchains.
4 years, 8 months ago (2016-04-19 17:29:48 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904473002/20001
4 years, 8 months ago (2016-04-19 17:30:59 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-19 18:55:30 UTC) #7
brucedawson
lgtm
4 years, 8 months ago (2016-04-19 21:16:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904473002/20001
4 years, 8 months ago (2016-04-19 21:21:26 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-19 21:26:08 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:16:36 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/440b117bb10d5c7e195a26cf974ccbd5886948b0
Cr-Commit-Position: refs/heads/master@{#388315}

Powered by Google App Engine
This is Rietveld 408576698