android_webview/native/aw_gl_functor.cc - Issue 1904453004: Transfer DrawGLFunctor ownership from AwContents to AwGLFunctor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_gl_functor.cc

Issue 1904453004: Transfer DrawGLFunctor ownership from AwContents to AwGLFunctor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/native/aw_gl_functor.h ('k') | android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_gl_functor.cc

diff --git a/android_webview/native/aw_gl_functor.cc b/android_webview/native/aw_gl_functor.cc

index cd88a7fe0af8bdaf69b81b447924494df0bdc810..60e3f05be8978d094df8e2ac460e2dbb9ca36a5f 100644

--- a/android_webview/native/aw_gl_functor.cc

+++ b/android_webview/native/aw_gl_functor.cc

@@ -41,13 +41,13 @@ void AwGLFunctor::OnParentDrawConstraintsUpdated() {

browser_view_renderer_->OnParentDrawConstraintsUpdated();

}

-bool AwGLFunctor::RequestDrawGL(bool wait_for_completion) {

+bool AwGLFunctor::RequestInvokeGL(bool wait_for_completion) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

JNIEnv* env = AttachCurrentThread();

ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);

if (obj.is_null())

return false;

- return Java_AwGLFunctor_requestDrawGL(env, obj.obj(), wait_for_completion);

+ return Java_AwGLFunctor_requestInvokeGL(env, obj.obj(), wait_for_completion);

}

void AwGLFunctor::DetachFunctorFromView() {