Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5579)

Unified Diff: android_webview/browser/render_thread_manager.cc

Issue 1904453004: Transfer DrawGLFunctor ownership from AwContents to AwGLFunctor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Flow-on renaming Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/render_thread_manager.cc
diff --git a/android_webview/browser/render_thread_manager.cc b/android_webview/browser/render_thread_manager.cc
index df7331a19a64058a3e1f9e0db7831fdbcff52cf8..db2fb83d2f0c2b56c8546f5319f14f45563ff1bf 100644
--- a/android_webview/browser/render_thread_manager.cc
+++ b/android_webview/browser/render_thread_manager.cc
@@ -144,7 +144,7 @@ void RenderThreadManager::ClientRequestDrawGLOnUI() {
DCHECK(ui_loop_->BelongsToCurrentThread());
ResetRequestDrawGLCallback();
g_request_draw_gl_tracker.Get().SetQueuedFunctorOnUi(this);
- if (!client_->RequestDrawGL(false)) {
+ if (!client_->RequestInvokeGL(false)) {
boliu 2016/04/20 16:49:09 Hmm... this should *almost* never happen now. Shou
g_request_draw_gl_tracker.Get().ResetPending();
LOG(ERROR) << "Failed to request GL process. Deadlock likely";
}
@@ -327,7 +327,7 @@ void RenderThreadManager::DeleteHardwareRendererOnUI() {
// onTrimMemory will result in an unnecessary Render Thread DrawGL call.
bool hardware_initialized = HasFrameOnUI();
if (hardware_initialized) {
- bool draw_functor_succeeded = client_->RequestDrawGL(true);
+ bool draw_functor_succeeded = client_->RequestInvokeGL(true);
if (!draw_functor_succeeded) {
LOG(ERROR) << "Unable to free GL resources. Has the Window leaked?";
// Calling release on wrong thread intentionally.
@@ -349,7 +349,7 @@ void RenderThreadManager::DeleteHardwareRendererOnUI() {
if (hardware_initialized) {
// Flush any invoke functors that's caused by ReleaseHardware.
- client_->RequestDrawGL(true);
+ client_->RequestInvokeGL(true);
}
}

Powered by Google App Engine
This is Rietveld 408576698