Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1904453002: Remove use_openssl variable (Closed)

Created:
4 years, 8 months ago by svaldez
Modified:
4 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@ios_final
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove use_openssl variable This removes the definition of use_openssl from build/common.gypi since nothing should be relying on it anymore. R=thakis@chromium.org BUG=604728 Committed: https://crrev.com/ba3958ab196964def88e432393b110f45f795ef8 Cr-Commit-Position: refs/heads/master@{#388539}

Patch Set 1 #

Patch Set 2 : Remove from crypto.gni #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M build/common.gypi View 4 chunks +0 lines, -9 lines 0 comments Download
M build/config/crypto.gni View 1 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
svaldez
4 years, 8 months ago (2016-04-19 15:11:56 UTC) #1
Nico
lgtm
4 years, 8 months ago (2016-04-19 15:16:13 UTC) #2
svaldez
On 2016/04/19 15:16:13, Nico wrote: > lgtm Ended up moving crypto.gni out to this CL ...
4 years, 8 months ago (2016-04-19 15:37:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904453002/20001
4 years, 8 months ago (2016-04-20 17:15:58 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-20 18:36:56 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:25:00 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ba3958ab196964def88e432393b110f45f795ef8
Cr-Commit-Position: refs/heads/master@{#388539}

Powered by Google App Engine
This is Rietveld 408576698