Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1904433002: [compiler] Avoid spamming --trace-opt with lookup failures. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Avoid spamming --trace-opt with lookup failures. This stops printing a log line for when a lookup in the optimized code map did not yield a result. Logging such a negative result that will inevitably trigger a compile anyways has little benefit and just spams the console unnecessarily. R=jkummerow@chromium.org Committed: https://crrev.com/51a6cd3ae450a28af2dcf2062ea7f6671d281852 Cr-Commit-Position: refs/heads/master@{#35623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/objects.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-19 12:46:25 UTC) #1
Jakob Kummerow
LGTM. Could have moved the output behind FLAG_trace_opt_verbose instead, but dropping it entirely is fine ...
4 years, 8 months ago (2016-04-19 13:11:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904433002/1
4 years, 8 months ago (2016-04-19 13:23:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 13:24:42 UTC) #5
nodir1
4 years, 8 months ago (2016-04-22 18:42:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51a6cd3ae450a28af2dcf2062ea7f6671d281852
Cr-Commit-Position: refs/heads/master@{#35623}

Powered by Google App Engine
This is Rietveld 408576698